#24358: Support vm_template for azurerm_virtual_desktop_host_pool resource #24369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catriona-m
requested changes
Jan 10, 2024
There was a problem hiding this comment.
Thanks for this @harshavmb, I've left a couple of minor comments but once those are fixed up I can take another look. It would also be good to include this property in a test. Thanks!
internal/services/desktopvirtualization/virtual_desktop_host_pool_resource.go
Outdated
Show resolved
Hide resolved
|
Hi @catriona-m , Indeed I wanted to add a test case but couldn't find some documentation about I shall check with the request initiator if he could provide me a sample template to play with. |
|
HI @harshavmb - just checking in to see if you were able to get the config needed to create a test for this? Thanks! |
Hi @catriona-m , I have added the test case now. Could you please re-review? |
katbyte
changed the title
katbyte
approved these changes
Feb 16, 2024
katbyte
added a commit
that referenced
this pull request
Feb 16, 2024
dduportal
added a commit
to jenkins-infra/azure
that referenced
this pull request
Feb 19, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
<h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>changes detected:
	"hashicorp/azurerm" updated from
"3.91.0" to "3.92.0" in file
".terraform.lock.hcl"</p>
<details>
<summary>3.92.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.92.0
FEATURES:

*
**New Data Source**: `azurerm_virtual_desktop_application_group`
([#24771](https://github.com/hashicorp/terraform-provider-azurerm/issues/24771))

ENHANCEMENTS:

*
provider: support for the feature flag
`postgresql_flexible_server.restart_server_on_configuration_value_change
property`
([#23811](https://github.com/hashicorp/terraform-provider-azurerm/issues/23811))
*
dependencies: updating to v0.20240214.1142753 of
`github.com/hashicorp/go-azure-sdk`
([#24889](https://github.com/hashicorp/terraform-provider-azurerm/issues/24889))
*
`automation`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24858](https://github.com/hashicorp/terraform-provider-azurerm/issues/24858))
*
`maintenance`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24819](https://github.com/hashicorp/terraform-provider-azurerm/issues/24819))
*
`containerapps`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24862](https://github.com/hashicorp/terraform-provider-azurerm/issues/24862))
*
`containerservices`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24872](https://github.com/hashicorp/terraform-provider-azurerm/issues/24872))
*
`timeseriesinsights`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24889](https://github.com/hashicorp/terraform-provider-azurerm/issues/24889))
*
`azurerm_container_app_environment`: support for the
`infrastructure_resource_group_name` property
([#24361](https://github.com/hashicorp/terraform-provider-azurerm/issues/24361))
*
`azurerm_cost_anomaly_alert` - support for the `subscription_id`
property
([#24258](https://github.com/hashicorp/terraform-provider-azurerm/issues/24258))
*
`azurerm_cosmosdb_account` - add default values for the
`consistency_policy` code block
([#24830](https://github.com/hashicorp/terraform-provider-azurerm/issues/24830))
*
`azurerm_dashboard_grafana` - support for the `smtp` block
([#24717](https://github.com/hashicorp/terraform-provider-azurerm/issues/24717))
*
`azurerm_key_vault_certificates` - support for the `tags` property
([#24857](https://github.com/hashicorp/terraform-provider-azurerm/issues/24857))
*
`azurerm_key_vault_secrets` - support for the `tags` property
([#24857](https://github.com/hashicorp/terraform-provider-azurerm/issues/24857))
*
`azurerm_orchestrated_virtual_machine_scale_set` - support for the
`additional_unattend_content` block
([#24292](https://github.com/hashicorp/terraform-provider-azurerm/issues/24292))
*
`azurerm_virtual_desktop_host_pool` - support for the `vm_template`
property
([#24369](https://github.com/hashicorp/terraform-provider-azurerm/issues/24369))

BUG
FIXES:

* `azurerm_container_app_environment`: avoid unwanted
changes when updating and using `log_analytics_workspace_id`
([#24303](https://github.com/hashicorp/terraform-provider-azurerm/issues/24303))
*
`azurerm_cosmosdb_account` - fixed regression in the `backup` code block
([#24830](https://github.com/hashicorp/terraform-provider-azurerm/issues/24830))
*
`azurerm_data_factory` - allow the `git_url` property to be blank/empty
([#24879](https://github.com/hashicorp/terraform-provider-azurerm/issues/24879))
*
`azurerm_linux_web_app_slot` - the `worker_count` property now works
correctly in the `site_config` block
([#24515](https://github.com/hashicorp/terraform-provider-azurerm/issues/24515))
*
`azurerm_linux_web_app` - support `off` for the `file_system_level`
property
([#24877](https://github.com/hashicorp/terraform-provider-azurerm/issues/24877))
*
`azurerm_linux_web_app_slot` - support `off` for the `file_system_level`
property
([#24877](https://github.com/hashicorp/terraform-provider-azurerm/issues/24877))
*
`azurerm_private_endpoint` - fixing an issue where updating the Private
Endpoint would remove any Application Security Group Association
([#24846](https://github.com/hashicorp/terraform-provider-azurerm/issues/24846))
*
`azurerm_search_service` - fixed the update function to adjust for
changed API behaviour
([#24837](https://github.com/hashicorp/terraform-provider-azurerm/issues/24837))
*
`azurerm_search_service` - fixed the update function to adjust for
changed API behaviour
([#24903](https://github.com/hashicorp/terraform-provider-azurerm/issues/24903))
*
`azurerm_windows_web_app` - support `off` for the `file_system_level`
property
([#24877](https://github.com/hashicorp/terraform-provider-azurerm/issues/24877))
*
`azurerm_windows_web_app_slot` - support `off` for the
`file_system_level` property
([#24877](https://github.com/hashicorp/terraform-provider-azurerm/issues/24877))


</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/3/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
1 task
rizkybiz
pushed a commit
to rizkybiz/terraform-provider-azurerm
that referenced
this pull request
Feb 21, 2024
…_pool resource (hashicorp#24369) * hashicorp#24358: Support vmTemplate for azurerm_virtual_desktop_host_pool resource * hashicorp#24358: Changes as per review comments * hashicorp#24358: Fix error * hashicorp#24358: Adding testcase for vm_template
rizkybiz
pushed a commit
to rizkybiz/terraform-provider-azurerm
that referenced
this pull request
Feb 21, 2024
rizkybiz
pushed a commit
to rizkybiz/terraform-provider-azurerm
that referenced
this pull request
Feb 29, 2024
…_pool resource (hashicorp#24369) * hashicorp#24358: Support vmTemplate for azurerm_virtual_desktop_host_pool resource * hashicorp#24358: Changes as per review comments * hashicorp#24358: Fix error * hashicorp#24358: Adding testcase for vm_template
rizkybiz
pushed a commit
to rizkybiz/terraform-provider-azurerm
that referenced
this pull request
Feb 29, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
vm_templateforazurerm_virtual_desktop_host_poolresource.Fixes #24358.