azurerm_postgresql_flexible_server - customer_managed_key. key_vault_key_id is now required
#24981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1091,7 +1091,7 @@ func flattenFlexibleServerAuthConfig(ac *servers.AuthConfig) interface{} { | |||
| } | |||
|
|
|||
| func expandFlexibleServerDataEncryption(input []interface{}) *servers.DataEncryption { | |||
| if len(input) == 0 { | |||
| if len(input) == 0 || input[0] == nil { | |||
There was a problem hiding this comment.
@neil-yechenwei an empty customer_managed_key block isn't valid - so rather than doing this key_vault_key_id should become Required, since that's always going to be required for a customer managed key - can we update this?
There was a problem hiding this comment.
Sure. Updated.
|
@tombuildsstuff , thanks for the suggestion. I updated PR. Please take another look. Thanks. Below is the test result I just now triggered and all related test cases passed.
|
katbyte
changed the title
azurerm_postgresql_flexible_server - update nil check for customer_managed_keyazurerm_postgresql_flexible_server - customer_managed_key. key_vault_key_id is now required
katbyte
added a commit
that referenced
this pull request
Feb 23, 2024
lemeurherve
pushed a commit
to jenkins-infra/azure
that referenced
this pull request
Feb 23, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
<h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>changes detected:
	"hashicorp/azurerm" updated from
"3.92.0" to "3.93.0" in file
".terraform.lock.hcl"</p>
<details>
<summary>3.93.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.93.0
*
**New Data Source**: `azurerm_express_route_circuit_peering`
([#24971](https://github.com/hashicorp/terraform-provider-azurerm/issues/24971))
*
**New Data Source**: `azurerm_storage_table_entities`
([#24973](https://github.com/hashicorp/terraform-provider-azurerm/issues/24973))
*
**New Resource**: `azurerm_dev_center_catalog`
([#24833](https://github.com/hashicorp/terraform-provider-azurerm/issues/24833))
*
**New Resource**: `azurerm_system_center_virtual_machine_manager_server`
([#24278](https://github.com/hashicorp/terraform-provider-azurerm/issues/24278))

BUG
FIXES:

* `azurerm_key_vault` - conditionally polling the Data
Plane endpoint when `public_network_access_enabled` is set to false
([#23823](https://github.com/hashicorp/terraform-provider-azurerm/issues/23823))
*
`azurerm_storage_account` - allow the `identity.type` property to be
`SystemAssigned, UserAssigned` when using a Customer Managed Key
([#24923](https://github.com/hashicorp/terraform-provider-azurerm/issues/24923))
*
`azurerm_automation_account` - prevent the `identity.identity_ids` User
Assigned identity being set when not specified in config
([#24977](https://github.com/hashicorp/terraform-provider-azurerm/issues/24977))

ENHANCEMENTS:

*
dependencies: updating to `v0.20240221.1170458` of
`hashicorp/go-azure-sdk`
([#24967](https://github.com/hashicorp/terraform-provider-azurerm/issues/24967))
*
dependencies: refactor `azurerm_spring_cloud_configuration_service` to
use `go-azure-sdk`
([#24918](https://github.com/hashicorp/terraform-provider-azurerm/issues/24918))
*
provider: support or the feature flag
`virtual_machine_scale_set.reimage_on_manual_upgrade`
([#22975](https://github.com/hashicorp/terraform-provider-azurerm/issues/22975))
*
`sentinel`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24962](https://github.com/hashicorp/terraform-provider-azurerm/issues/24962))
*
`sqlvirtualmachines`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24912](https://github.com/hashicorp/terraform-provider-azurerm/issues/24912))
*
`nginx` : updating to use `2024-01-01-preview`
([#24868](https://github.com/hashicorp/terraform-provider-azurerm/issues/24868))
*
`azurerm_cosmosdb_account` - support for the `backup.tier` property
([#24595](https://github.com/hashicorp/terraform-provider-azurerm/issues/24595))
*
`azurerm_linux_virtual_machine` - the `virtual_machine_scale_set_id`
proeprty can now be changed without creating a new resource
([#24768](https://github.com/hashicorp/terraform-provider-azurerm/issues/24768))
*
`azurerm_machine_learning_workspace` - support for the
`managed_network.isolation_mode` property
([#24951](https://github.com/hashicorp/terraform-provider-azurerm/issues/24951))
*
`azurerm_private_dns_resolver_inbound_endpoint` - support the `static`
value for the `private_ip_allocation_method` property
([#24952](https://github.com/hashicorp/terraform-provider-azurerm/issues/24952))
*
`azurerm_postgresql_flexible_server` - expose the `storage_tier` field
([#24892](https://github.com/hashicorp/terraform-provider-azurerm/issues/24892))
*
`azurerm_redis_cache` - support for the
`preferred_data_persistence_auth_method` property
([#24370](https://github.com/hashicorp/terraform-provider-azurerm/issues/24370))
*
`azurerm_servicebus_namespace` - support for the
`premium_messaging_partitions` property
([#24676](https://github.com/hashicorp/terraform-provider-azurerm/issues/24676))
*
`azurerm_windows_virtual_machine` - the `virtual_machine_scale_set_id`
proeprty can now be changed without creating a new resource
([#24768](https://github.com/hashicorp/terraform-provider-azurerm/issues/24768))

BUG
FIXES:

* `azurerm_cognitive_deployment` - the
`version_upgrade_option` property can not be updated without creating a
new resource
([#24922](https://github.com/hashicorp/terraform-provider-azurerm/issues/24922))
*
`azurerm_data_protection_backup_vault` - support or the `soft_delete`
and `retention_duration_in_days` properties
([#24775](https://github.com/hashicorp/terraform-provider-azurerm/issues/24775))
*
`azurerm_data_factory_pipeline` - correctly handle incorrect header
values
([#24921](https://github.com/hashicorp/terraform-provider-azurerm/issues/24921))
*
`azurerm_kusto_cluster` - `optimized_auto_scale` is now updated after
`sku` has been updated
([#24906](https://github.com/hashicorp/terraform-provider-azurerm/issues/24906))
*
`azurerm_key_vault_certificate` - will now only update the
`lifetime_action` of the certificate block unless otherwise required
([#24755](https://github.com/hashicorp/terraform-provider-azurerm/issues/24755))
*
`azurerm_linux_virtual_machine_scale_set` - correctly include
`public_ip_prefix_id` during updates
([#24939](https://github.com/hashicorp/terraform-provider-azurerm/issues/24939))
*
`azurerm_postgresql_flexible_server` - the
`customer_managed_key.key_vault_key_id` property is now required
([#24981](https://github.com/hashicorp/terraform-provider-azurerm/issues/24981))
*
`azurerm_nginx_deployment` - changing the `sku` property now creates a
new resource
([#24905](https://github.com/hashicorp/terraform-provider-azurerm/issues/24905))
*
`azurerm_orchestrated_virtual_machine_scale_set` - the `disk_size_gb`
and `lun` parameters of `data_disks` are optional now
([#24944](https://github.com/hashicorp/terraform-provider-azurerm/issues/24944))
*
`azurerm_storage_account` - change order of API calls to be GET-then-PUT
ratehr then PATCHES
([#23935](https://github.com/hashicorp/terraform-provider-azurerm/issues/23935))
*
`azurerm_storage_account` - improve the validation around the
`immutability_policy` being used with `blob_properties`
([#24938](https://github.com/hashicorp/terraform-provider-azurerm/issues/24938))
*
`azurerm_security_center_setting` - prevent a bug when name is
`SENTINEL`
([#24497](https://github.com/hashicorp/terraform-provider-azurerm/issues/24497))
*
`azurerm_windows_virtual_machine_scale_set` - correctly include
`public_ip_prefix_id` during updates
([#24939](https://github.com/hashicorp/terraform-provider-azurerm/issues/24939))




</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/19/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
rizkybiz
pushed a commit
to rizkybiz/terraform-provider-azurerm
that referenced
this pull request
Feb 29, 2024
…_managed_key` (hashicorp#24981) * azurerm_postgresql_flexible_server - update nil check for customer_managed_key * update code
rizkybiz
pushed a commit
to rizkybiz/terraform-provider-azurerm
that referenced
this pull request
Feb 29, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24957