Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_postgresql_flexible_server - customer_managed_key. key_vault_key_id is now required #24981

Merged
merged 2 commits into from Feb 23, 2024
Merged

azurerm_postgresql_flexible_server - customer_managed_key. key_vault_key_id is now required #24981

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5aed36
azurerm_postgresql_flexible_server - update nil check for customer_ma…
neil-yechenwei Feb 22, 2024
2cfa733
update code
neil-yechenwei Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/services/postgres/postgresql_flexible_server_resource.go
View file
Open in desktop
Expand Up @@ -1091,7 +1091,7 @@ func flattenFlexibleServerAuthConfig(ac *servers.AuthConfig) interface{} {
}

func expandFlexibleServerDataEncryption(input []interface{}) *servers.DataEncryption {
if len(input) == 0 {
if len(input) == 0 || input[0] == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei an empty customer_managed_key block isn't valid - so rather than doing this key_vault_key_id should become Required, since that's always going to be required for a customer managed key - can we update this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Updated.

return nil
}
v := input[0].(map[string]interface{})
Expand Down