Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: API Management with virtual networks #3667

Closed
wasfree opened this issue Jun 14, 2019 · 3 comments · Fixed by #5769
Closed

Feature Request: API Management with virtual networks #3667

wasfree opened this issue Jun 14, 2019 · 3 comments · Fixed by #5769
Labels
enhancement service/api-management upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Milestone

Comments

@wasfree
Copy link
Contributor

wasfree commented Jun 14, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It should be possible to use a API Management in combination with virtual network. This will make it more comfortable to use just internal backends instead of public backends with IP restrictions or client certificates. So this network configuration is not implemented in azurerm_api_management yet, it is also possible to use this feature with "Developer" tier now (before it was only available in "Premium" tier).

New or Affected Resource(s)

  • azurerm_api_management

Potential Terraform Configuration

resource "azurerm_api_management" "test" {
  name                = "example-apim"
  location            = "${azurerm_resource_group.test.location}"
  resource_group_name = "${azurerm_resource_group.test.name}"
  publisher_name      = "My Company"
  publisher_email     = "company@terraform.io"

  network_type = "${networkType}"

  network_configuration {
    subnet_id  = "${subnetId}"
    vnet_id    = "${vnetId}"
    subnetname = "${subnetName}"
  }  

  sku {
    name     = "Developer"
    capacity = 1
  }
}

This is how it looks like from API prospective:

[...]
    "virtualNetworkType": "${networkType}"
    "virtualNetworkConfiguration": {
      "subnetResourceId": "${subnetId}",
      "vnetid": "${vnetId}",
      "subnetname": "${subnetName}"
    },
[...]

References

@tombuildsstuff
Copy link
Member

hey @NickMetz

Thanks for opening this issue :)

Whilst there's a PR which attempted to add support for this in #2582 - unfortunately this is blocked on a bug in the Swagger used to generate the Azure SDK - once that's fixed we'll be able to circle back around and take another look at this.

Since this is blocked on an upstream issue (but there's a PR blocked on this) - rather than keeping this issue open I'm going to close this issue in favour of the PR which adds support for this: #2582 - once the upstream issue is resolved we'll re-open that PR and continue adding support for this.

Thanks!

@tombuildsstuff tombuildsstuff added enhancement service/api-management upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR labels Jun 14, 2019
@ghost
Copy link

ghost commented Jul 15, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@hashicorp hashicorp unlocked this conversation Apr 23, 2020
@hashicorp hashicorp locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement service/api-management upstream/microsoft Indicates that there's an upstream issue blocking this issue/PR
Projects
None yet
3 participants