Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Event Grid Domain Topics and Domain-Scope Event Subscriptions #4097

Closed
dreasan opened this issue Aug 15, 2019 · 6 comments · Fixed by #6859
Closed

Support for Event Grid Domain Topics and Domain-Scope Event Subscriptions #4097

dreasan opened this issue Aug 15, 2019 · 6 comments · Fixed by #6859

Comments

@dreasan
Copy link

dreasan commented Aug 15, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

There is currently no visible support for adding a domain topic or a domain scope subscription with the provider.

New or Affected Resource(s)

  • azurerm_eventgrid_domain_topic
  • azurerm_eventgrid_domain_scope_event_subscription

References

It's related to this issue, although not exactly the request (as it's suggested to add a topic type)
#2855

@jrauschenbusch
Copy link
Contributor

Hi @dreasan,

imho azurerm_eventgrid_domain_scope_event_subscription does not need to be an dedicated resource.

See example:

resource "azurerm_eventgrid_domain" "test" {
    name =  "test-domain"
}

resource "azurerm_eventgrid_event_subscription" "test" {
    ...
    scope = azurerm_eventgrid_domain.test.id
    ...
}

The missing resource azurerm_eventgrid_domain_topic is implemented within my linked PR.

@dreasan
Copy link
Author

dreasan commented Mar 2, 2020

hi @jrauschenbusch,

I would agree that the subscription to a domain topic can and should better be handled within the existing resource: azurerm_eventgrid_event_subscription

thank you for your contribution!

@jrauschenbusch
Copy link
Contributor

@dreasan what i meant was, that this should already work using the scope property of azurerm_eventgrid_event_subscription. only a domain topic resource was missing, to also be able to subscribe to topics residing in domains.

@dreasan
Copy link
Author

dreasan commented Mar 2, 2020

@jrauschenbusch got it, thanks!

@katbyte katbyte added this to the v2.10.0 milestone May 14, 2020
katbyte pushed a commit that referenced this issue May 14, 2020
Adds new resource azurerm_eventgrid_domain_topic

Fixes #4097
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants