Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Private Links in AKS #5148

Closed
jlpedrosa opened this issue Dec 12, 2019 · 4 comments · Fixed by #5161
Closed

Support for Private Links in AKS #5148

jlpedrosa opened this issue Dec 12, 2019 · 4 comments · Fixed by #5161

Comments

@jlpedrosa
Copy link
Contributor

jlpedrosa commented Dec 12, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Private link in AKS has been released as public preview . There have been new fields added to the API to support this feature.

New or Affected Resource(s)

azurerm_kubernetes_cluster

Potential Terraform Configuration

resource "azurerm_kubernetes_cluster" "example" {
  name                = "example-aks1"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  dns_prefix          = "exampleaks1"

  default_node_pool {
    name       = "default"
    node_count = 1
    vm_size    = "Standard_D2_v2"
  }
  api_server_authorized_ip_ranges = [ "10.0.0.0/8", "192.168.1.0/24" ]
  private_link_enabled = true  
}

References

REST API model

I'll be working into A PR for this feature if it's ok with @tombuildsstuff and @katbyte

@tombuildsstuff
Copy link
Contributor

@jlpedrosa that'd be awesome, thanks!

One thing of note - since this is in Preview would you mind adding a disclaimer like below to this property:

-> At this time Private Link is in Public Preview

@jlpedrosa
Copy link
Contributor Author

@tombuildsstuff Of course, noted.

katbyte pushed a commit that referenced this issue Dec 18, 2019
Add support for aks private link (public preview).
Required version upgrade of the azure-sdk to use the new API, (2019-06-01) -> (2019-10-01).

During the development I saw that the datasource was lacking some fileds added to the resource in other PRs (api_server_authorized_ip_ranges) So i've added them too as in the new API it goes together.

Fixes: #5148
@katbyte katbyte added this to the v1.40.0 milestone Dec 19, 2019
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants