Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_lb - support for the private_ip_address_version property #5590

Merged
merged 3 commits into from Mar 10, 2020

Conversation

smarterclayton
Copy link
Contributor

Azure allows load balancers to have an allocated private ip address
version in their frontend configuration to select between IPv4 and
IPv6, like NICs. Make setting the version on load balancers consistent
with NICs.

@ghost ghost added the size/S label Feb 1, 2020
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @smarterclayton, these changes look good but we're seeing a crash while I testing.

Azure allows load balancers to have an allocated private ip address
version in their frontend configuration to select between IPv4 and
IPv6, like NICs. Make setting the version on load balancers consistent
with NICs.
@ghost ghost added size/XS and removed size/S labels Feb 20, 2020
@smarterclayton
Copy link
Contributor Author

Updated, PTAL

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @smarterclayton,

This looks good aside from we need at add it to the complete test and update the documentation.

@ghost ghost added documentation size/M and removed size/XS labels Mar 9, 2020
@katbyte katbyte added this to the v2.1.0 milestone Mar 9, 2020
@katbyte katbyte changed the title loadbalancer: Allow setting private_ip_address_version azurerm_lb - support for the private_ip_address_version property Mar 10, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @smarterclayton,

I hope you don't mind but i pushed the required changes to merge this. LGTM now 👍

@katbyte katbyte merged commit 56cd84e into hashicorp:master Mar 10, 2020
katbyte added a commit that referenced this pull request Mar 10, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Mar 11, 2020
@ghost
Copy link

ghost commented Apr 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants