Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for azurerm_data_factory_integration_runtime_self_hosted #6503

Closed
pearcec opened this issue Apr 16, 2020 · 5 comments
Closed

Support for azurerm_data_factory_integration_runtime_self_hosted #6503

pearcec opened this issue Apr 16, 2020 · 5 comments

Comments

@pearcec
Copy link
Contributor

pearcec commented Apr 16, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

See the link below. In an enterprise environment it is common to have a bare shared integration runtime. This resource would create the linkage. Hopefully the testing won't require an actual IR and we can pass in a fake.

New or Affected Resource(s)

  • azurerm_data_factory_integration_self_hosted

Potential Terraform Configuration

resource "azurerm_data_factory_integration_runtime_self_hosted" "host" {
  name                = "host" 
  resource_group_name = "shared-rg"
  data_factory_name   = "shared-df"
  description         = "" # (optional)
}

# linked self-hosted DF identity needs Contributor access

resource "azurerm_data_factory_integration_runtime_self_hosted" "ir" {
  name                = "ir" 
  resource_group_name = "rg"
  data_factory_name   = "df"
  description         = "" # (optional)
  rbac_authentication {
    resource_id       = azurerm_data_factory_integration_runtime_self_hosted.host.id
  }
}

The ir name has the following validate: ^[A-Za-z0-9]+(?:-[A-Za-z0-9]+)*$

The code and final names is still a WIP.

References

@pearcec pearcec changed the title Support for azurerm_data_factory_integration_runtime_linked_self_hosted Support for azurerm_data_factory_integration_runtime_self_hosted Apr 16, 2020
@markti
Copy link
Contributor

markti commented Apr 17, 2020

@pearcec do we need a separate resource for linkedInfo? It appears that linkedInfo will always have a 1-1 relationship with a SelfHostedIntegrationRuntime. In that case, I'd suggest flattening it and putting the linkedInfo properties (key / rbac) directly on the SelfHostedRuntime.

@pearcec
Copy link
Contributor Author

pearcec commented Apr 17, 2020

key_authorization use is indeterminate. Received vague error and found no explanation of use in docs, or powershell calls.

{"error":{"code":"InvalidSharingIntegrationRuntimeOperation","message":"The administrative operation on shared integration runtime is not allowed via linked integration runtime 'acctestirs ht200417164656073154'. Error message: The payload is not valid for RBAC authorization. The actual authorization type is 'Key'..","target":null,"details":null}}

pearcec pushed a commit to pearcec/terraform-provider-azurerm that referenced this issue Apr 19, 2020
This resource type supports but a standalone Self-hosted and linking via rbac_authorization. The
key_authorization has no documentation other than the REST interface.  The Powershell Cmdlet does
not make use of it.  So it has been left out.

A full test is setup and necessary for the linked environment to work.

An example and documetnation is included to make the linked setup easier to understand.  People
may also reference the test case.

Fixing issue hashicorp#6503.
pearcec pushed a commit to pearcec/terraform-provider-azurerm that referenced this issue May 15, 2020
This resource type supports but a standalone Self-hosted and linking via rbac_authorization. The
key_authorization has no documentation other than the REST interface.  The Powershell Cmdlet does
not make use of it.  So it has been left out.

A full test is setup and necessary for the linked environment to work.

An example and documetnation is included to make the linked setup easier to understand.  People
may also reference the test case.

Fixing issue hashicorp#6503.
pearcec pushed a commit to pearcec/terraform-provider-azurerm that referenced this issue Jun 12, 2020
This resource type supports but a standalone Self-hosted and linking via rbac_authorization. The
key_authorization has no documentation other than the REST interface.  The Powershell Cmdlet does
not make use of it.  So it has been left out.

A full test is setup and necessary for the linked environment to work.

An example and documetnation is included to make the linked setup easier to understand.  People
may also reference the test case.

Fixing issue hashicorp#6503.
katbyte pushed a commit that referenced this issue Jun 16, 2020
…6535)

This resource type supports but a standalone Self-hosted and linking via rbac_authorization. The
key_authorization has no documentation other than the REST interface. The Powershell Cmdlet does
not make use of it. So it has been left out.

A full test is setup and necessary for the linked environment to work.

An example and documetnation is included to make the linked setup easier to understand. People
may also reference the test case.

Fixing issue #6503.
@katbyte katbyte added this to the v2.15.0 milestone Jun 16, 2020
@katbyte
Copy link
Collaborator

katbyte commented Jun 16, 2020

closed by #6503

@katbyte katbyte closed this as completed Jun 16, 2020
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.15.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.15.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants