Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for threatIntelligenceMode property on azurerm_firewall #7336

Closed
rhys96 opened this issue Jun 16, 2020 · 5 comments · Fixed by #7437
Closed

Support for threatIntelligenceMode property on azurerm_firewall #7336

rhys96 opened this issue Jun 16, 2020 · 5 comments · Fixed by #7437
Assignees
Milestone

Comments

@rhys96
Copy link

rhys96 commented Jun 16, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

By default, the Azure Firewall is created with a Threat Intelligence mode of 'Alert'. Microsoft now offers "Off, Alert & Deny" modes. The mode selection is offered in the New-AzFirewall Azure CLI command. It would be really useful to be able to configure this attribute in Terraform.

The linked issue states the issue was resolved, however, I can't see it mentioned in any of the Terraform documentation for azurerm-firewall.

Linked issue: resource_arm_firewall, resource_arm_firewall_application_rule_collection – Mssql and Threat Intelligence #4595

New or Affected Resource(s)

  • azurerm_firewall

Potential Terraform Configuration

resource "azurerm_firewall" "this" {
  name                = local.firewall_name
  location            = data.azurerm_resource_group.this.location
  resource_group_name = data.azurerm_resource_group.this.name
  threat_intelligence_mode = "Alert"

  ip_configuration {
    name                 = format("%s-ipconfig", local.firewall_name)
    subnet_id            = module.firewall_subnet.subnet_ids[0]
    public_ip_address_id = azurerm_public_ip.this.id
  }
}

References

@rhys96 rhys96 changed the title Azure Resource Manager: Azure Firewall Threat Intelligence modeSupport for [thing] Azure Resource Manager: Azure Firewall Threat Intelligence mode Jun 16, 2020
@rhys96 rhys96 changed the title Azure Resource Manager: Azure Firewall Threat Intelligence mode Support for threatIntelligenceMode property on azurerm_firewall Jun 16, 2020
@magodo magodo self-assigned this Jun 23, 2020
@magodo
Copy link
Collaborator

magodo commented Jun 23, 2020

Hi @rhys96 Thank you for letting us know this 👍
The linked issue indeed didn't address this gap, I will hopefully submit a PR soon to fix it!

@rhys96
Copy link
Author

rhys96 commented Jun 23, 2020

I had already created a PR request [#7414](Adding AzureFirewallThreatIntelMode property to firewall_resource), but I couldn't figure out how to add it to the issue (this is my first contribution to a project). Thank you for adding the PR :)

@magodo
Copy link
Collaborator

magodo commented Jun 23, 2020

That is easy, you only need to mention the issue in the description of the PR in format of #issue_number (e.g. #7336 in this case).

@katbyte katbyte added this to the v2.16.0 milestone Jun 23, 2020
@ghost
Copy link

ghost commented Jun 25, 2020

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants