azurerm_mssql_database support 0 for min_capacity
#8308
Conversation
There was a problem hiding this comment.
hi @yupwei68
Thanks for this PR.
Taking a look through here it appears that we can add 0 as an allowed value here (as 1 and 2 are) - which should solve this and provide examples of valid values here; at the same time can we also add an acceptance test to cover this missing use-case? If we can fix those up then we should be able to take another look
Thanks!
|
Hi @tombuildsstuff Thanks for your comments. Please continue reviewing. |
| @@ -123,7 +122,7 @@ func resourceArmMsSqlDatabase() *schema.Resource { | |||
| Type: schema.TypeFloat, | |||
| Optional: true, | |||
| Computed: true, | |||
| ValidateFunc: azValidate.FloatInSlice([]float64{0.5, 0.75, 1, 1.25, 1.5, 1.75, 2, 2.25, 2.5, 3, 4, 5}), | |||
| ValidateFunc: validate.MsSqlDatabaseMinCapacity, | |||
There was a problem hiding this comment.
can we add an Acceptance Test to provision a Database with the Capacity of 0 to confirm the Basic SKU / #8226 is fixed
katbyte
changed the title
azurerm_mssql_database min_capacity change validationazurerm_mssql_database support 0 for min_capacity
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Fix #8226