Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_ip_groups #8556

Merged
merged 6 commits into from
Sep 24, 2020
Merged

New resource: azurerm_ip_groups #8556

merged 6 commits into from
Sep 24, 2020

Conversation

manicminer
Copy link
Member

  • azurerm_firewall_network_rule_collection: support destination_ip_groups and source_ip_groups for rules
  • azurerm_firewall_nat_rule_collection: support source_ip_groups for rules
  • azurerm_firewall_application_rule_collection: support source_ip_groups for rules
  • azurerm_ip_groups new resource and data source

Closes: #7047

@manicminer manicminer force-pushed the f/firewall branch 2 times, most recently from bf9dc2a to 1e83cac Compare September 22, 2020 00:09
@manicminer manicminer changed the title Firewall [WIP] New resource: azurerm_ip_groups Sep 22, 2020
@manicminer manicminer marked this pull request as ready for review September 22, 2020 08:28
@manicminer manicminer requested a review from a team September 22, 2020 08:28
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one minor comments about resource group names LGTP 👍

@tombuildsstuff tombuildsstuff modified the milestones: v2.29.0, v2.30.0 Sep 24, 2020
@katbyte katbyte merged commit 7a21635 into master Sep 24, 2020
@katbyte katbyte deleted the f/firewall branch September 24, 2020 20:18
katbyte added a commit that referenced this pull request Sep 24, 2020
@alexwilcox9
Copy link
Contributor

Hi, I see this PR is adding a data source as well as a resource but the changelog only mentions the data source
Is this an error in the changelog or will the resource be in a different release?

manicminer added a commit that referenced this pull request Sep 30, 2020
@manicminer
Copy link
Member Author

@alexwilcox9 looks like this is an accidental omission. both the resource and data source should make it in the next release. Good catch, thanks!

@ghost
Copy link

ghost commented Oct 1, 2020

This has been released in version 2.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.30.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for IP Groups in Azure Firewall
4 participants