Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_app_service_slot_config_names #12809

Closed
wants to merge 2 commits into from

Conversation

zhcli
Copy link
Contributor

@zhcli zhcli commented Aug 2, 2021

Purpose:

@jackofallops
Copy link
Member

hey @zhcli

Thanks for this PR and apologies for the delay in reviewing it.

You may have noticed that as a part of v3.0 of the AzureRM Provider we've been reworking App Service to better fit within Terraform, which has led to the development of multiple new resources which have since superseded the original resources - which have been available in Beta for a while and will GA in v3.0 of the AzureRM Provider.

Whilst adding a specific resource to track the sticky slots is one way to solve this, we have a feeling this may end up introducing other issues - and may instead need locating within another resource unfortunately. Unfortunately some of the design choices within App Service (including where Slots can override the parent App Service/Function) can lead to problems (such as conflicts) within Terraform if this isn't accounted for.

As such whilst I'd like to thank you for this contribution, and apologies again for the delay in reviewing it - as we need to take a different direction here I'm going to close this PR for the moment in favour of the original issue #1440 - but this is something we're hoping to re-evaluate in the not-too-distant future to properly support this within the App Service rework mentioned above.

Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Sticky AppSetting and ConectionStrings - azurerm_app_service, azurerm_app_service_slot
3 participants