Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_synapse_workspace - mark tenant_id as computed #13464

Merged
merged 1 commit into from Sep 23, 2021

Conversation

owenfarrell
Copy link
Contributor

@owenfarrell owenfarrell commented Sep 23, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Summary

This pull request marks the tenant_id field as computed to avoid extraneous diff calculations if/when the field is omitted from the configuration.

Related: #13290

Output from acceptance testing:

$ make acctests SERVICE='synapse' TESTARGS='-run="^TestAccSynapseWorkspace_azdo"' TESTTIMEOUT='120m' 
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/synapse -run="^TestAccSynapseWorkspace_azdo" -timeout 120m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccSynapseWorkspace_azdo
=== PAUSE TestAccSynapseWorkspace_azdo
=== RUN   TestAccSynapseWorkspace_azdoTenant
=== PAUSE TestAccSynapseWorkspace_azdoTenant
=== CONT  TestAccSynapseWorkspace_azdo
=== CONT  TestAccSynapseWorkspace_azdoTenant
--- PASS: TestAccSynapseWorkspace_azdo (678.60s)
--- PASS: TestAccSynapseWorkspace_azdoTenant (765.76s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/synapse       768.730s

Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
@katbyte katbyte added this to the v2.78.0 milestone Sep 23, 2021
@katbyte katbyte changed the title Compute Azure DevOps tenant ID when omitted from configuration azurerm_synapse_workspace - mark tenant_id as computed Sep 23, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @owenfarrell - LGTM ‼️

@katbyte katbyte merged commit 676de38 into hashicorp:main Sep 23, 2021
katbyte added a commit that referenced this pull request Sep 23, 2021
@owenfarrell owenfarrell deleted the synapse-azdo-cross-tenant branch September 23, 2021 03:42
@github-actions
Copy link

This functionality has been released in v2.78.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants