New Resource: Autoscale Settings #135

whiskeyjay · 2017-06-27T00:59:55Z

This PR adds a new resource: azurerm_autoscale_setting. It enables auto-scaling for VM Scale Sets and Compute Availability Sets.

Acceptance test results:

$ make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMAutoscaleSetting_importBasic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMAutoscaleSetting_importBasic -timeout 120m
=== RUN   TestAccAzureRMAutoscaleSetting_importBasic
--- PASS: TestAccAzureRMAutoscaleSetting_importBasic (394.08s)
PASS
ok   github.com/terraform-providers/terraform-provider-azurerm/azurerm 394.097s

$ make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMAutoscaleSetting_importRecurrence'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMAutoscaleSetting_importRecurrence -timeout 120m
=== RUN   TestAccAzureRMAutoscaleSetting_importRecurrence
--- PASS: TestAccAzureRMAutoscaleSetting_importRecurrence (452.83s)
PASS
ok   github.com/terraform-providers/terraform-provider-azurerm/azurerm 452.842s

$ make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMAutoscaleSetting_importFixedDate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMAutoscaleSetting_importFixedDate -timeout 120m
=== RUN   TestAccAzureRMAutoscaleSetting_importFixedDate
--- PASS: TestAccAzureRMAutoscaleSetting_importFixedDate (384.38s)
PASS
ok   github.com/terraform-providers/terraform-provider-azurerm/azurerm 384.402s

make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMAutoscaleSetting_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMAutoscaleSetting_basic -timeout 120m
=== RUN   TestAccAzureRMAutoscaleSetting_basic
--- PASS: TestAccAzureRMAutoscaleSetting_basic (373.71s)
PASS
ok   github.com/terraform-providers/terraform-provider-azurerm/azurerm 373.723s

make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMAutoscaleSetting_recurrence'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMAutoscaleSetting_recurrence -timeout 120m
=== RUN   TestAccAzureRMAutoscaleSetting_recurrence
--- PASS: TestAccAzureRMAutoscaleSetting_recurrence (461.39s)
PASS
ok   github.com/terraform-providers/terraform-provider-azurerm/azurerm 461.412s

$ make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMAutoscaleSetting_fixedDate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMAutoscaleSetting_fixedDate -timeout 120m
=== RUN   TestAccAzureRMAutoscaleSetting_fixedDate
--- PASS: TestAccAzureRMAutoscaleSetting_fixedDate (392.70s)
PASS
ok   github.com/terraform-providers/terraform-provider-azurerm/azurerm 392.710s

tombuildsstuff · 2017-06-27T10:27:48Z

Fixes #50

tombuildsstuff

Hey @whiskeyjay

Thanks for this PR - I've taken a look and left some comments in-line - but this is off to a good start :)

Thanks!

tombuildsstuff · 2017-06-27T18:23:08Z

azurerm/resource_arm_autoscale_setting.go

+			"profile": {
+				Type:     schema.TypeList,
+				Required: true,
+				MinItems: 1,


given this is Required - MinItems: 1 is inferred and this line isn't needed :)

tombuildsstuff · 2017-06-27T18:23:28Z

azurerm/resource_arm_autoscale_setting.go

+					Schema: map[string]*schema.Schema{
+						"name": {
+							Type:     schema.TypeString,
+							Required: true,


should this be ForceNew?

No, this "name" is more like a label for the profile, it can be changed without having to create a new profile. It has the same behavior on Azure portal.

tombuildsstuff · 2017-06-27T18:23:36Z

azurerm/resource_arm_autoscale_setting.go

+						"capacity": {
+							Type:     schema.TypeSet,
+							Required: true,
+							MinItems: 1,


(as above) this line isn't needed

tombuildsstuff · 2017-06-27T18:24:17Z

azurerm/resource_arm_autoscale_setting.go

+								Schema: map[string]*schema.Schema{
+									"minimum": {
+										Type:     schema.TypeInt,
+										Required: true,


if memory serves there's limits to each of these, of ~1000 hosts - is that still valid? if so - should we add validation here?

Good catch. The value should be in the range of [1, 100] - yes, for VMSS you can go up to 1000 (but actually limited by the allowed core numbers of the subscription), but for Autoscale Settings, somehow it is limited to 100. On portal there is a input validation and the REST API returns error if the value exceeds 100.

tombuildsstuff · 2017-06-27T18:24:24Z

azurerm/resource_arm_autoscale_setting.go

+									"maximum": {
+										Type:     schema.TypeInt,
+										Required: true,
+									},


Check added.

tombuildsstuff · 2017-06-27T18:52:31Z

azurerm/resource_arm_autoscale_setting.go

+	recurrenceSet := config["recurrence"].(*schema.Set).List()
+
+	if recurrenceSet == nil || len(recurrenceSet) == 0 {
+		return recurrence, fmt.Errorf("recurrence not defined")


why not return nil here instead?

tombuildsstuff · 2017-06-27T18:52:43Z

azurerm/resource_arm_autoscale_setting.go

+	fixedDateSet := config["fixed_date"].(*schema.Set).List()
+
+	if fixedDateSet == nil || len(fixedDateSet) == 0 {
+		return timeWindow, fmt.Errorf("fixed_date not defined")


why not return nil here instead?

tombuildsstuff · 2017-06-27T18:54:04Z

azurerm/resource_arm_autoscale_setting.go

+
+func listTimeZoneNames() []string {
+	return []string{
+		"Dateline Standard Time", "UTC-11", "Hawaiian Standard Time", "Alaskan Standard Time",


is it possible to use a regex for ex. UTC+11 here instead, rather than listing each of these out?

I don't know why but unfortunately these are the only values accepted. Tried to pass "UTC+8" which is not in the list and the REST call returned error.

Updated doc to point to the REST API doc page where all allowed values can be found.

tombuildsstuff · 2017-06-27T18:56:24Z

website/docs/r/autoscale_setting.html.markdown

+
+`email` supports the following:
+
+* `send_to_subscription_administrator` - (Required) Specifies whether to send email notifications to the subscription administrator.


Should this be defaulted?

The default behavior on portal is not sending emails, and since email property is optional, I think it is fine not to set a default value in the schema - if users do need email notifications, they specify email properties.

tombuildsstuff · 2017-06-27T18:56:27Z

website/docs/r/autoscale_setting.html.markdown

+
+* `send_to_subscription_administrator` - (Required) Specifies whether to send email notifications to the subscription administrator.
+
+* `send_to_subscription_co_administrator` - (Required) Specifies whether to send email notifications to the subscription co-administrator.


Should this be defaulted?

StephenWeatherford · 2017-06-28T00:00:35Z

website/docs/r/autoscale_setting.html.markdown

+page_title: "Azure Resource Manager: azurerm_autoscale_setting"
+sidebar_current: "docs-azurerm-resource-autoscale-setting"
+description: |-
+  Create an autoscale setting.


Suggest: Create an autoscale setting that can be applied to an Azure Virtual Machine Scale Set

does this also cover other resources like Web Apps etc - or is it specific to VMSS?

Virtual Machine Scale Sets, Cloud Services, and App Service - Web Apps.

👍 could we update this to mention those, similar to Stephen's suggestion?

StephenWeatherford

Left suggestions

StephenWeatherford · 2017-06-28T00:01:11Z

website/docs/r/autoscale_setting.html.markdown

+page_title: "Azure Resource Manager: azurerm_autoscale_setting"
+sidebar_current: "docs-azurerm-resource-autoscale-setting"
+description: |-
+  Create an autoscale setting.


Should there be a pointer from VMSS docs to here?

Added a link to Autoscale Settings doc.

StephenWeatherford · 2017-06-28T00:06:18Z

website/docs/r/autoscale_setting.html.markdown

+## Example Usage
+
+```hcl
+variable "time_zone" {


Is this used?

No, removed.

StephenWeatherford · 2017-06-28T00:09:01Z

website/docs/r/autoscale_setting.html.markdown

+  enabled             = true
+  resource_group_name = "${azurerm_resource_group.test.name}"
+  location            = "${azurerm_resource_group.test.location}"
+  target_resource_uri = "${azurerm_virtual_machine_scale_set.test.id}"


URI or ID? Seems like target_resource_id would be better. I think that consistency in the rest of azurerm terraform provider and in how it's used trumps consistency with the REST API in this case. That's my opinion at any rate.

The ARM template also uses "uri". Although Azure PowerShell call it "id". I'll just keep it aligned with ARM template. As long as the doc tells what value to specify it should be fine.

In Terraform we tend to use id rather than uri/url - so I'd suggest it'd be better to change this to match the convention?

Changed to id.

StephenWeatherford · 2017-06-28T00:09:29Z

website/docs/r/autoscale_setting.html.markdown

+    rule {
+      "metric_trigger" {
+        "metric_name"         = "Percentage CPU"
+        "metric_resource_uri" = "${azurerm_virtual_machine_scale_set.test.id}"


StephenWeatherford · 2017-06-28T00:31:59Z

website/docs/r/autoscale_setting.html.markdown

+the number of cores that are available in your subscription.
+
+* `default` - (Required) Specifies the number of instances that are available for scaling if metrics are not available for 
+evaluation. The default is only used if the current instance cout is lower than the default.


StephenWeatherford · 2017-06-28T19:45:46Z

azurerm/config.go

@@ -13,6 +13,7 @@ import (
 	"github.com/Azure/azure-sdk-for-go/arm/containerservice"


Any mistake whatsoever in the values sent to Azure causes 400 unknown with no info on where/what the problem is. Can you check with fiddler to see if that's really all we're getting, and report an error to Azure (if it is) or go sdk (if sdk is not giving us the error info).

Same on portal, when something goes wrong with autoscale settings, it just says "bad request". :(

StephenWeatherford · 2017-06-28T19:47:32Z

azurerm/resource_arm_autoscale_setting.go

+												"days": {
+													Type:     schema.TypeList,
+													Required: true,
+													Elem: &schema.Schema{


StringInSlice?

List doesn't support this.

could we add a custom validation method for this? does this also need to be case insensitive for the values in Azure?

Passing values like "sunday" will not result in any REST API errors, however, the web portal UI will not show "Sunday" as checked (sigh). And by custom validation method do you mean custom logic when reading the values from configuration? Because the adding the ValidateFunc here will result in runtime error: ValidateFunc is not yet supported on lists or sets.

however, the web portal UI will not show "Sunday" as checked (sigh)

It's minor, but I'd suggest it might be worth filing a bug with the Portal team about that - in the meantime we should be able to cast this value to Title Case internally before calling CreateOrUpdate, which should solve the immediate issue? I've not tested it - but I'm assuming a DiffSuppressFunc to ignore the case will work here?

StephenWeatherford · 2017-06-28T19:48:13Z

website/docs/r/autoscale_setting.html.markdown

+* `hours` - (Required) Specifies a collection of hours that the profile takes effect on. Values supported are 0 to 23 on the 24-hour 
+clock (AM/PM times are not supported).
+
+* `minutes` - (Required) Specifies a collection of minutes at which the profile takes effect at.


at which the profile takes effect.

StephenWeatherford · 2017-06-28T19:49:01Z

website/docs/r/autoscale_setting.html.markdown

+
+* `time_zone` - (Required) Specifies the time zone of the start and end times for the profile.
+
+* `start` - (Required) Specifies the start time for the profile.


format for start/end?

StephenWeatherford · 2017-06-28T19:56:03Z

azurerm/resource_arm_autoscale_setting.go

+									},
+								},
+							},
+							Set: resourceAzureRmAutoscaleDefaultHash,


@tombuildsstuff Tom, can you comment on this? My understanding is that you should just be able to not specify a set function, and in fact that that is recommend, and a default will be used for you.

I know Jay said he had troubles getting that to work.

whiskeyjay · 2017-06-30T07:25:39Z

Made a bunch of changes to address the comments. Also re-ran the acc tests.

tombuildsstuff

Hey @whiskeyjay

Sorry for the delay in re-reviewing this!

Thanks for the continued effort here - I've taken another look and this is looking really good - I've commented a few minor issues, and if we can fix them up this should be good to merge :)

Thanks!

tombuildsstuff · 2017-07-07T19:17:35Z

azurerm/resource_arm_autoscale_setting.go

+													Type:     schema.TypeString,
+													Required: true,
+													// ValidateFunc: validation.StringInSlice(listTimeZoneNames(), false),
+												},


can we add this back in?

tombuildsstuff · 2017-07-07T19:20:08Z

azurerm/resource_arm_autoscale_setting.go

+												"days": {
+													Type:     schema.TypeList,
+													Required: true,
+													Elem: &schema.Schema{


could we add a custom validation method for this? does this also need to be case insensitive for the values in Azure?

tombuildsstuff · 2017-07-07T19:22:22Z

azurerm/resource_arm_autoscale_setting.go

+
+	parameters := insights.AutoscaleSettingResource{
+		Name:             &name,
+		Type:             &resourceType,


from memory, we shouldn't need to specify this (in every other API it's pre-filled by Azure)

You are right. I removed it.

tombuildsstuff · 2017-07-07T19:23:08Z

azurerm/resource_arm_autoscale_setting.go

+				Type:     schema.TypeBool,
+				Required: true,
+			},
+			"target_resource_uri": {


could we make this target_resource_id to match the convention within Terraform?

tombuildsstuff · 2017-07-07T19:23:42Z

azurerm/resource_arm_autoscale_setting.go

+			d.SetId("")
+			return nil
+		}
+		return fmt.Errorf("Error making Read request on Autoscale Setting %s: %s", name, err)


the second argument here needs to be %+v as it's an error

Right. Fixed.

tombuildsstuff · 2017-07-07T19:55:53Z

azurerm/resource_arm_autoscale_setting_test.go

+    } 
+
+    resource "azurerm_autoscale_setting" "test" {
+      name                = "myAutoscaleSetting"


+1 could we give this a unique name?

tombuildsstuff · 2017-07-07T19:56:03Z

azurerm/resource_arm_autoscale_setting_test.go

+    } 
+
+    resource "azurerm_autoscale_setting" "test" {
+      name                = "myAutoscaleSetting"


+1 could we give this a unique name?

tombuildsstuff · 2017-07-07T19:57:37Z

website/azurerm.erb

@@ -174,6 +174,15 @@
              </ul>
            </li>

+            <li<%= sidebar_current("docs-azurerm-resource-autoscale-setting") %>>
+              <a href="#">Monitoring And Diagnostics Resources</a>


can we make this Monitoring Resources for now, until some Diagnostic specific resources are supported?

tombuildsstuff · 2017-07-07T19:58:49Z

website/docs/r/autoscale_setting.html.markdown

+page_title: "Azure Resource Manager: azurerm_autoscale_setting"
+sidebar_current: "docs-azurerm-resource-autoscale-setting"
+description: |-
+  Create an autoscale setting.


👍 could we update this to mention those, similar to Stephen's suggestion?

tombuildsstuff · 2017-07-07T19:59:57Z

website/docs/r/autoscale_setting.html.markdown

+    "email" {
+      "send_to_subscription_administrator"    = true
+      "send_to_subscription_co_administrator" = true
+    }


we shouldn't need the quote's around the keys? (also goes for the tests)

Quotes removed.

whiskeyjay · 2017-07-15T00:23:12Z

@tombuildsstuff I have addressed most of the new comments. Had a few questions though, could you take a look and clarify? Thanks!

tombuildsstuff

Hey @whiskeyjay

Thanks for the continued effort on this - apologies for the delay in reviewing this, I'd reviewed but not hit submit 🤦‍♂️

I've taken another look through and commented on a few minor things - however this is nearly there! The main remaining question for me is around this line which I think might want an update to the Schema so the user doesn't have to input escaped JSON?

Thanks!

tombuildsstuff · 2017-07-20T18:55:11Z

website/docs/r/autoscale_setting.html.markdown

+  location            = "${azurerm_resource_group.test.location}"
+  target_resource_id  = "${azurerm_virtual_machine_scale_set.test.id}"
+  profile {
+    name = "{\"name\":\"defaultProfile\",\"for\":\"Weekends\"}"


Is this valid? If so - should we be sending this field as {name="foo"} in all requests / should we be updating the schema to match?

tombuildsstuff · 2017-08-08T09:28:26Z

azurerm/resource_arm_autoscale_setting.go

+
+	"regexp"
+
+	"strings"


really minor could we run goimports -w ./azurerm/ to tidy this up?

tombuildsstuff · 2017-08-08T09:29:36Z

azurerm/resource_arm_autoscale_setting.go

+							Type:          schema.TypeSet,
+							Optional:      true,
+							MaxItems:      1,
+							ConflictsWith: []string{"profile.recurrence"},


does this work? I have a feeling this syntax isn't supported?

tombuildsstuff · 2017-08-08T09:32:19Z

azurerm/resource_arm_autoscale_setting.go

+												"days": {
+													Type:     schema.TypeList,
+													Required: true,
+													Elem: &schema.Schema{


however, the web portal UI will not show "Sunday" as checked (sigh)

It's minor, but I'd suggest it might be worth filing a bug with the Portal team about that - in the meantime we should be able to cast this value to Title Case internally before calling CreateOrUpdate, which should solve the immediate issue? I've not tested it - but I'm assuming a DiffSuppressFunc to ignore the case will work here?

tombuildsstuff · 2017-08-08T09:34:14Z

azurerm/resource_arm_autoscale_setting.go

+			},
+			"enabled": {
+				Type:     schema.TypeBool,
+				Required: true,


🤔 is it worth making this Optional and Defaulting it to true?

tombuildsstuff · 2017-08-08T09:35:17Z

azurerm/resource_arm_autoscale_setting.go

+	name := id.Path["autoscalesettings"]
+
+	if name == "" {
+		return fmt.Errorf("Cannot find resource name in Resource ID for Autoscale Setting")


I'd argue it'd be worth returning the ID at the end of this error message to make it easier to diagnose?

tombuildsstuff · 2017-08-08T09:38:28Z

azurerm/resource_arm_autoscale_setting.go

+	capacity := make(map[string]interface{})
+	capacity["minimum"], _ = strconv.Atoi(*profile.Capacity.Minimum)
+	capacity["maximum"], _ = strconv.Atoi(*profile.Capacity.Maximum)
+	capacity["default"], _ = strconv.Atoi(*profile.Capacity.Default)


Thanks for opening that, this isn't a blocker by any means - but worth getting fixed for a future release if it's a bug :)

tombuildsstuff · 2017-08-08T10:24:14Z

azurerm/resource_arm_autoscale_setting_test.go

+			return fmt.Errorf("Bad: Autoscale Setting %q (resource group: %q) does not exist", autoscaleSettingName, resourceGroup)
+		}
+
+		return fmt.Errorf("Bad: Get on autoscaleSettingsClient: %s", err)


can we make this formatting argument %+v?

tombuildsstuff · 2017-08-08T10:26:21Z

azurerm/resource_arm_autoscale_setting_test.go

+	return fmt.Sprintf(`
+    variable "time_zone" {
+      type    = "string"
+      default = "Pacific Standard Time"


Reflecting on this, maybe not, I was wondering if we could get away with the user inputting UTC-8 rather than Pacific Standard Time - but that'd actually just complicate things

tombuildsstuff · 2017-08-08T10:28:17Z

website/docs/r/autoscale_setting.html.markdown

+page_title: "Azure Resource Manager: azurerm_autoscale_setting"
+sidebar_current: "docs-azurerm-resource-autoscale-setting"
+description: |-
+  Create an autoscale setting that can be applied to Virtual Machine Scale Sets, Cloud Services and App Service - Web Apps.


I might be wrong, but aren't Cloud Services part of ASM? In which case - do they belong in this list?

minor: can we match the convention seen in the CosmosDB Resource by updating App Service - Web Apps to App Service (formally "Web Apps")

bugblatter2016 · 2017-11-17T11:47:46Z

Hi Folks, any idea if / when this feature will get progressed? This is something we could really use!

Cheers

s7anley · 2017-11-22T11:57:37Z

Hi! Thanks for working on this feature! Any chance you have time to finish it @whiskeyjay?

StephenWeatherford · 2017-11-25T02:51:59Z

@tombuildsstuff Tom, are you guys going to take this PR over since @whiskeyjay and I are no longer working on terraform?

tombuildsstuff · 2017-11-28T13:22:03Z

@StephenWeatherford sure.

Given that @whiskeyjay is no longer working on this PR I'm going to close this PR for the moment (but leave the branch around so it can be picked up) - and I'll pick this up in the near future.

saada · 2018-02-14T01:05:47Z

@tombuildsstuff, is this still in progress? If not, I'm interested in picking it up and working on it. Can you point me to the latest branch and remaining issues?

tombuildsstuff · 2018-02-14T03:13:10Z

@saada it's on our roadmap but we've not got to it yet - but if you're able to pick it up that'd be awesome :)

Given a lot's happened since this branch was started, I'd probably suggest pulling the resources out (linked below) into a new branch off master and fixing the build:

https://github.com/whiskeyjay/terraform-provider-azurerm/blob/autoscale/azurerm/resource_arm_autoscale_setting.go

https://github.com/whiskeyjay/terraform-provider-azurerm/blob/autoscale/azurerm/resource_arm_autoscale_setting_test.go

https://github.com/whiskeyjay/terraform-provider-azurerm/blob/autoscale/website/docs/r/autoscale_setting.html.markdown

The most important thing to note since this PR was first created is that the Azure SDK now has switched to exposing multiple API versions - rather than just pinning to one explicitly. As such you'll need to switch any imports currently using github.com/Azure/azure-sdk-for-go/arm to github.com/Azure/azure-sdk-for-go/services/...

I'd suggest the most prudent thing to do regarding reviewing would be to first get this compiling and then to open a PR from which we can re-review; the comments above should be valid - but given a lot of time has passed it's probably simplest to re-review it

Hope that helps :)

EtienneDeneuve · 2018-06-28T14:02:35Z

Does this features almost done ? I need that for one customer, how may I help ?

tombuildsstuff · 2018-06-29T09:15:21Z

Locking this PR in favour of #1140 - since this is where this is being tracked.

whiskeyjay added 9 commits June 12, 2017 15:27

Skeleton for autoscale settings support

f244167

Merge branch 'master' into autoscale

7e3bf4c

Adding insights package

4160f80

Tweaking the schema def

4558552

A bit more code to get things done

8e239ed

A few tweaks to the schema

b75a5a8

Added validation for a bunch of properties

aeb9404

Documentation

db72912

Acceptance tests

b3d80d6

tombuildsstuff added enhancement new-resource labels Jun 27, 2017

tombuildsstuff mentioned this pull request Jun 27, 2017

Feature Request: Azure App Gateway #18

Closed

Fix vendor.json

46d84fa

tombuildsstuff requested changes Jun 27, 2017

View reviewed changes

StephenWeatherford reviewed Jun 28, 2017

View reviewed changes

StephenWeatherford suggested changes Jun 28, 2017

View reviewed changes

whiskeyjay added 2 commits June 29, 2017 22:11

Address PR comments

e8ab04e

Added link to the REST API doc

95d0487

tombuildsstuff reviewed Jul 7, 2017

View reviewed changes

whiskeyjay added 4 commits July 8, 2017 22:47

Changed resource_uri to resource_id, also added more samples

ce63deb

Address PR comments

4399fb5

A bit more adjustments

ca25e57

Fixing tests

e397a55

Merge changes from upstream

29db256

tombuildsstuff reviewed Aug 8, 2017

View reviewed changes

tombuildsstuff added the waiting-response label Aug 8, 2017

rcarun added the service/vmss Virtual Machine Scale Sets label Oct 11, 2017

rcarun added the M1 label Oct 11, 2017

rcarun added this to the M1 milestone Oct 11, 2017

tombuildsstuff modified the milestones: M1, Future Oct 12, 2017

tombuildsstuff removed the M1 label Oct 12, 2017

tombuildsstuff closed this Nov 28, 2017

YuriyKishchenko mentioned this pull request Apr 19, 2018

New Resource: Autoscale Settings #1140

Merged

katbyte removed the waiting-response label Jun 6, 2018

hashicorp locked and limited conversation to collaborators Jun 29, 2018

tombuildsstuff modified the milestones: Future, Being Sorted Oct 25, 2018


		`email` supports the following:

		* `send_to_subscription_administrator` - (Required) Specifies whether to send email notifications to the subscription administrator.


		* `send_to_subscription_administrator` - (Required) Specifies whether to send email notifications to the subscription administrator.

		* `send_to_subscription_co_administrator` - (Required) Specifies whether to send email notifications to the subscription co-administrator.

		@@ -13,6 +13,7 @@ import (
		"github.com/Azure/azure-sdk-for-go/arm/containerservice"


		* `time_zone` - (Required) Specifies the time zone of the start and end times for the profile.

		* `start` - (Required) Specifies the start time for the profile.

New Resource: Autoscale Settings #135

New Resource: Autoscale Settings #135

Conversation

whiskeyjay commented Jun 27, 2017

tombuildsstuff commented Jun 27, 2017

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tombuildsstuff Jun 28, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StephenWeatherford left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

whiskeyjay commented Jun 30, 2017

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

whiskeyjay commented Jul 15, 2017

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tombuildsstuff Jun 28, 2017 •

edited