Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mysql_flexible_server_configuration: New resource to support configuration on mysql_flexible_server #13831

Merged
merged 5 commits into from Oct 21, 2021

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Oct 21, 2021

Fixes #13824

Functionality, docs and code is 99% copy of azurerm_mysql_configuration but for azurerm_mysql_flexible_server instead of azurerm_mysql_server.

Acceptance Test

❯ go install && make acctests SERVICE='mysql' TESTARGS='-run=TestAccMySQLFlexibleServerConfiguration_'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/mysql -run=TestAccMySQLFlexibleServerConfiguration_ -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMySQLFlexibleServerConfiguration_characterSetServer
=== PAUSE TestAccMySQLFlexibleServerConfiguration_characterSetServer
=== RUN   TestAccMySQLFlexibleServerConfiguration_interactiveTimeout
=== PAUSE TestAccMySQLFlexibleServerConfiguration_interactiveTimeout
=== RUN   TestAccMySQLFlexibleServerConfiguration_logSlowAdminStatements
=== PAUSE TestAccMySQLFlexibleServerConfiguration_logSlowAdminStatements
=== CONT  TestAccMySQLFlexibleServerConfiguration_characterSetServer
=== CONT  TestAccMySQLFlexibleServerConfiguration_logSlowAdminStatements
=== CONT  TestAccMySQLFlexibleServerConfiguration_interactiveTimeout
--- PASS: TestAccMySQLFlexibleServerConfiguration_interactiveTimeout (532.41s)
--- PASS: TestAccMySQLFlexibleServerConfiguration_characterSetServer (533.17s)
--- PASS: TestAccMySQLFlexibleServerConfiguration_logSlowAdminStatements (585.12s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mysql 586.671s

@aristosvo aristosvo marked this pull request as ready for review October 21, 2021 15:44
@katbyte katbyte added this to the v2.82.0 milestone Oct 21, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aristosvo - LGTM ❄️

@katbyte katbyte merged commit 663dfab into hashicorp:main Oct 21, 2021
katbyte added a commit that referenced this pull request Oct 21, 2021
@github-actions
Copy link

This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2021
@aristosvo aristosvo deleted the mysql/flexible_server_configuration branch November 21, 2021 15:59
@aristosvo aristosvo restored the mysql/flexible_server_configuration branch April 14, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for azurerm_mysql_flexible_server_configuration
2 participants