Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function app consumption plan bug #1515

Merged
merged 6 commits into from
Jul 16, 2018
Merged

Function app consumption plan bug #1515

merged 6 commits into from
Jul 16, 2018

Commits on Jul 7, 2018

  1. Do not load WEBSITE_CONTENT app settings when on a consumption plan

    @ranieuwe
    ranieuwe committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    dc57466 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bug-appservice-function-consumption

    @ranieuwe
    ranieuwe committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    dafae77 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. Inverse the dynamic plan check, thanks @APErebus

    @ranieuwe
    ranieuwe committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    cb19e80 View commit details
    Browse the repository at this point in the history

  2. '%s' -> %q for safety

    @ranieuwe
    ranieuwe committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    c71f674 View commit details
    Browse the repository at this point in the history

  3. Add a nil check

    @ranieuwe
    ranieuwe committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    b683149 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2018

  1. Added tests to ensure the settings are removed: 

    ```
$ acctests azurerm TestAccAzureRMFunctionApp_basic
=== RUN   TestAccAzureRMFunctionApp_basic
--- PASS: TestAccAzureRMFunctionApp_basic (111.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	111.938s
```

```
$ acctests azurerm TestAccAzureRMFunctionApp_consumptionPlan
=== RUN   TestAccAzureRMFunctionApp_consumptionPlan
--- PASS: TestAccAzureRMFunctionApp_consumptionPlan (143.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	143.406s
```
    @tombuildsstuff
    tombuildsstuff committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    342665d View commit details
    Browse the repository at this point in the history