Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_synapse_workspace_key - can not be correctly rotated #15897

Merged
merged 6 commits into from Mar 22, 2022
Merged

azurerm_synapse_workspace_key - can not be correctly rotated #15897

merged 6 commits into from Mar 22, 2022

Conversation

ms-henglu
Copy link
Contributor

image

katbyte
katbyte requested changes Mar 22, 2022
View reviewed changes
internal/services/synapse/synapse_workspace_key_resource_test.go Outdated
check.That(data.ResourceName).ExistsInAzure(r),
),
},
// CMK takes a while to activate, so validation against the plan tends to fail.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be waiting on activation then? with a state wait until it is done so this never fails?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @katbyte ,

Yes, I've added the waiting part in the first commit. And I've removed this comments in the second commit. Please take another look, thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only the the update function? what about create? shouldn't it be there too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right, I've added another commit to add it in both create and update.

@ms-henglu
Copy link
Contributor Author

Hi @katbyte , testcases are all passed, would you please take another look? Thanks!
image

@ms-henglu ms-henglu requested a review from katbyte March 22, 2022 03:55
@katbyte katbyte changed the title fix synapse workspace cmk rotation azurerm_synapse_workspace_key - can not be correctly rotated Mar 22, 2022
katbyte
katbyte approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu - LGTM 🏗️

@katbyte katbyte merged commit 5ddc7eb into hashicorp:main Mar 22, 2022
@github-actions github-actions bot added this to the v3.0.0 milestone Mar 22, 2022
katbyte added a commit that referenced this pull request Mar 22, 2022
@katbyte
CHANGELOG.md for #15897
3fcd138
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
service/synapse size/L
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ms-henglu @katbyte