Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synapse_integration_runtime_azure- locations supports Auto Resolve #17111

Conversation

qiqingzhang
Copy link
Contributor

@qiqingzhang qiqingzhang commented Jun 6, 2022

link to #17092

public pr for synapse_integration_runtime_azure- locations supports Auto Resolve

test result after update:
image

TestAccSynapseIntegrationRuntimeAzure_autoResolve:
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @heiazuo - LGTM aside from that we should add a test for this?

@qiqingzhang qiqingzhang force-pushed the feat-synapse_integration_runtime_azure-supports-locations branch from fead81d to f12b975 Compare June 28, 2022 04:24
@github-actions github-actions bot added size/S and removed size/XS labels Jun 28, 2022
@qiqingzhang
Copy link
Contributor Author

Hi @katbyte ,
Test case added, please take another look, Thanks.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎩

@katbyte katbyte merged commit df08819 into hashicorp:main Jul 6, 2022
katbyte added a commit that referenced this pull request Jul 6, 2022
@github-actions github-actions bot added this to the v3.13.0 milestone Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v3.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants