Fix image tests with dangling os disk #17297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test result |
stephybun
approved these changes
Jun 20, 2022
|
This functionality has been released in v3.11.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
sergelogvinov
pushed a commit
to sergelogvinov/terraform-provider-azurerm
that referenced
this pull request
Jul 11, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests use
azurerm_virtual_machine, which has dangling os disk preventing the deletion of resource group, addingdelete_os_disk_on_terminationto fix themInvolved tests are:
TestAccImage_customImageFromVMWithUnmanagedDisks
TestAccImage_customImageFromVMWithManagedDisks
TestAccSharedImageVersion_specializedImageVersionByVM
TestAccSharedImageVersion_specializedImageVersionBySnapshot