App Service: Virtual Network Integration

[tombuildsstuff]

This PR adds support for integrating an App Service (and App Service Slot) with a Virtual Network

$ acctests azurerm TestAccAzureRMAppService_virtualNetwork

=== RUN   TestAccAzureRMAppService_virtualNetwork
--- PASS: TestAccAzureRMAppService_virtualNetwork (194.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	194.471s

Fixes #1445

[tombuildsstuff]

Tests pass:

[katbyte]

LGTM Tom 👍

[mat-mcloughlin]

Just as a comment on this from my own experiments.

Creating this link adds a AppServiceCertificate.cer into the root certificates of the application gateway. This can easily be blown away if you update the gateway breaking the connection.

Is there anyway to avoid this happening?

[tombuildsstuff]

@mat-mcloughlin it should be possible to make the certificates Computed as well as Optional (https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/resource_arm_application_gateway.go), which would avoid this being removed (presuming you’re not setting any certificates). Mind opening a separate issue? Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!