azurerm_synapse_firewall_rule - ensure the firewall is ready
#19227
Conversation
| stateChangeConf := &pluginsdk.StateChangeConf{ | ||
| Pending: []string{string(synapse.ProvisioningStateProvisioning)}, | ||
| Target: []string{string(synapse.ProvisioningStateSucceeded)}, | ||
| Refresh: func() (result interface{}, state string, err error) { | ||
| resp, err := client.Get(ctx, id.ResourceGroup, id.WorkspaceName, id.Name) | ||
| if err != nil { | ||
| return nil, "Error", err | ||
| } | ||
| return resp, string(resp.ProvisioningState), err | ||
| }, | ||
| MinTimeout: 30 * time.Second, | ||
| ContinuousTargetOccurence: 3, | ||
| Timeout: time.Until(deadline), | ||
| } |
There was a problem hiding this comment.
is there a Swagger bug tracking this API issue? if the Future is being polled on (above) this should be Succeeded at the end of the LRO?
There was a problem hiding this comment.
Hi, I've added the swagger issue to the comment.
if the Future is being polled on (above) this should be Succeeded at the end of the LRO?
Yes, but it might not take effect immediately, so I add ContinuousTargetOccurence: 3, to ensure it's working.
There was a problem hiding this comment.
Hi, I've added the swagger issue to the comment.
👍
if the Future is being polled on (above) this should be Succeeded at the end of the LRO?
Yes, but it might not take effect immediately, so I add ContinuousTargetOccurence: 3, to ensure it's working.
FWIW a Resource Manager operation should be entirely completed when the LRO is marked as ProvisioningState: Succeeded, the ContinuousTargetOccurence would be a workaround until the LRO is fixed.
There was a problem hiding this comment.
Yes, it's a workaround.
|
This functionality has been released in v3.32.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
fixes #13510