Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support slash in name and label property of azurerm_app_configuration_feature #19470

Merged
merged 2 commits into from
Dec 14, 2022
Merged

support slash in name and label property of azurerm_app_configuration_feature #19470

merged 2 commits into from
Dec 14, 2022

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Nov 29, 2022 •
edited

fix #19437

Screenshot 2022-11-29 at 15 38 50

@ziyeqf ziyeqf mentioned this pull request Nov 29, 2022
Closed
1 task
@ziyeqf ziyeqf marked this pull request as ready for review November 29, 2022 07:39
@ziyeqf ziyeqf force-pushed the tengzh/issue/app_configuration branch from 231e9b9 to 230dd55 Compare December 1, 2022 05:12
@ziyeqf ziyeqf force-pushed the tengzh/issue/app_configuration branch from 669e56e to 585f3f2 Compare December 12, 2022 08:05
@ziyeqf
Copy link
Contributor Author

ziyeqf commented Dec 12, 2022

running testsing

katbyte
katbyte approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM 🍄

@katbyte katbyte merged commit 55d6a35 into hashicorp:main Dec 14, 2022
@krukowskid krukowskid mentioned this pull request Dec 16, 2022
Closed
1 task
@ziyeqf ziyeqf mentioned this pull request Dec 19, 2022
Merged
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@ziyeqf @favoretti
support slash in name and label property of `azurerm_app_configur…
d9f441e 
…ation_feature` (hashicorp#19470)

fix hashicorp#19437
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
service/app-configuration size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azurerm_app_configuration_feature breaks state when using slashes
2 participants
@ziyeqf @katbyte