New Resource: azurerm_monitor_metric_alert

[JunyiYi]

Description

In this pull request, I implemented a new Azure monitoring resource in M4 called metric alerts. It will monitor the metrics (such as transactions count, CPU percentage, etc.) of one or more resources. Together with the azurerm_monitor_activitylog_alert, they are called the unified alerts in Azure monitor.

Related Issues

This resource will realize the requirements specified in #2007 .

References

Resource Description: https://docs.microsoft.com/en-us/azure/monitoring-and-diagnostics/alert-metric-overview?toc=/azure/azure-monitor/toc.json
REST API Reference: https://docs.microsoft.com/en-us/rest/api/monitor/metricalerts/createorupdate

Remarks

This resource is different than azurerm_metric_alertrule (which is called classic alerts in Azure). Actually this resource deprecates the old one.

[katbyte]

Hi @JunyiYi,

Thanks for the new resource, i've given it a quick look and left some minor comments inline. However it appears both the tests and documentation is missing? Once we have those added can do a more in-depth review and get this merged 🙂

[JunyiYi]

Thanks @katbyte for the reviewing. I have changed the code accordingly. Considering this is a similar resource to azurerm_monitor_activitylog_alert, you might also provide comments in that PR as well.

[katbyte]

@JunyiYi,

LGTM 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!