Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable vetshadow linter #2175

Merged
merged 2 commits into from
Nov 2, 2018
Merged

Enable vetshadow linter #2175

merged 2 commits into from
Nov 2, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Oct 29, 2018

#2163 should be merged first

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

This passes the linting locally - but fails in Travis with an OOM error 🙃

@katbyte katbyte merged commit 36a71fb into master Nov 2, 2018
@katbyte katbyte deleted the shadow-lint branch November 2, 2018 21:18
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants