Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Management: ensuring a Key Vault Child ID is passed #2189

Merged
merged 2 commits into from
Oct 31, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Fixes #2137

```
=== RUN   TestAccAzureRMValidateKeyVaultChildID
--- PASS: TestAccAzureRMValidateKeyVaultChildID (0.00s)
PASS
```
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked a little out of band about the circular dependency issue, but since it sounds like there's a plan there, LGTM. 🚀

@tombuildsstuff tombuildsstuff merged commit 46eadc3 into master Oct 31, 2018
@tombuildsstuff tombuildsstuff deleted the b/apim-keyvaultid branch October 31, 2018 17:54
tombuildsstuff added a commit that referenced this pull request Oct 31, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants