Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_nginx_configuration: skip nginx configuration acc tests #24041

Closed
wants to merge 2 commits into from

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Nov 28, 2023

The new Nginx Service API will create the default configuration during the Nginx deployment, So Terraform cannot create the configuration resource anymore... It's a known issue now: https://docs.nginx.com/nginxaas/azure/known-issues/. So skip the Acc Tests. Users have to import the default configuration first and then manage it by Terraform.

@tombuildsstuff
Copy link
Contributor

@wuxu92 rather than skipping these tests we should fix this issue - however is this a breaking change to the Service?

Is it possible to create multiple Configurations within a single Deployment? If so, we should delete the default Configuration when creating the Deployment (as we do for API Management) - if it's only possible to have a single Configuration then we should be instead moving the Configuration into the Deployment resource.

@wuxu92
Copy link
Contributor Author

wuxu92 commented Nov 28, 2023

@tombuildsstuff Yes, It is a breaking change from the API. We can create only single one configuration which is named as default. skip the test and uipdate the document is a short-term of provisioning configuration by Terraform. I'll try to move the configuration into the Depolyment later.

@tombuildsstuff
Copy link
Contributor

Taking a look at the original PR, it appears this has only ever supported a single item as the Swagger definition only supports the value default therefore this resource will want deprecating as a part of moving this into the azurerm_nginx_deployment resource since this should be inlined within the Deployment resource, since there's a 1:1 relationship between a Deployment and a Configuration here.

@wuxu92 since this PR is going to need to be substantially reworked, is it worth closing this PR and opening a new PR for that instead?

Copy link

github-actions bot commented May 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants