-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider: don't attempt to register unavailable RPs #24071
Conversation
It's not obvious to me whether The failed check is unrelated to this PR, as best as I can tell. The output mentions a datadog file:
Which it looks like was fixed here: but is for some reason showing up as an issue here. (I may be able to work around it by a rebase -- let me know if you want me to give that a shot!) |
@ChandlerSwift - typically when its calling out a fire not changed you need to just merge to the latest commit on main |
Got it; rebased -- thanks! |
Another error, another rebase! :) |
Hey @katbyte -- happy new year! Anything I can do to help move this along? I did a preemptive rebase to hopefully head off any workflow failures. |
PR #23380 addressed issue #21785, but with that fix, when an unavailable resource provider was found, it would still be added to the list of providers to be registered, and then fail upon attempted registration. This skips registration for providers which are neither registered nor unregistered. Co-Authored-By: Jeff Smith <toxicglados@gmail.com> Co-Authored-By: Ryan Wozney <wozneyr@users.noreply.github.com>
Rebased again to fix that workflow! |
Oops! That PR wasn't intended to close this one; I didn't realize a mention (without the "closes " syntax would do that 🤦 @katbyte would you mind reopening this PR? Seems like only repo maintainers have PR reopening powers. Otherwise I'd be happy to open a new PR if that's easier for any reason! |
@ChandlerSwift Thanks for helping us find this accidental close. GitHub is showing that there has been a force-push or recreation on the main branch and will not allow me to reopen this issue. If you could open a new PR that would be greatly appreciated! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
PR #23380 addressed issue #21785, but with that fix, when an unavailable resource provider was found, it would still be added to the list of providers to be registered, and then fail upon attempted registration.
Fixes #21785
This skips registration for providers which are neither registered nor unregistered.