Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: don't attempt to register unavailable RPs #24071

Closed
wants to merge 1 commit into from
Closed

provider: don't attempt to register unavailable RPs #24071

wants to merge 1 commit into from

Conversation

ChandlerSwift
Copy link
Contributor

PR #23380 addressed issue #21785, but with that fix, when an unavailable resource provider was found, it would still be added to the list of providers to be registered, and then fail upon attempted registration.

Fixes #21785

This skips registration for providers which are neither registered nor unregistered.

@ChandlerSwift
Copy link
Contributor Author

ChandlerSwift commented Dec 5, 2023

It's not obvious to me whether waiting-response is waiting on a response to me or from me, but in case it's supposed to be from me:

The failed check is unrelated to this PR, as best as I can tell. The output mentions a datadog file:

internal/services/datadog/datadog_monitor_tag_rule_resource.go    245				LogRules:    expandLogRules(d.Get("log").([]interface{})),

Which it looks like was fixed here:

https://github.com/hashicorp/terraform-provider-azurerm/pull/22806/files#diff-0ba664d8eebd366bc33a40325ff672294df2001a4d860910c389c3f9b74e7834L245

but is for some reason showing up as an issue here. (I may be able to work around it by a rebase -- let me know if you want me to give that a shot!)

@katbyte
Copy link
Collaborator

katbyte commented Dec 7, 2023

@ChandlerSwift - typically when its calling out a fire not changed you need to just merge to the latest commit on main

@ChandlerSwift
Copy link
Contributor Author

Got it; rebased -- thanks!

@ChandlerSwift
Copy link
Contributor Author

Another error, another rebase! :)

@ChandlerSwift
Copy link
Contributor Author

Hey @katbyte -- happy new year! Anything I can do to help move this along? I did a preemptive rebase to hopefully head off any workflow failures.

PR #23380 addressed issue #21785, but with that fix, when an unavailable
resource provider was found, it would still be added to the list of
providers to be registered, and then fail upon attempted registration.

This skips registration for providers which are neither registered nor
unregistered.

Co-Authored-By: Jeff Smith <toxicglados@gmail.com>
Co-Authored-By: Ryan Wozney <wozneyr@users.noreply.github.com>
@ChandlerSwift
Copy link
Contributor Author

Rebased again to fix that workflow!

@ChandlerSwift
Copy link
Contributor Author

Oops! That PR wasn't intended to close this one; I didn't realize a mention (without the "closes " syntax would do that 🤦

@katbyte would you mind reopening this PR? Seems like only repo maintainers have PR reopening powers. Otherwise I'd be happy to open a new PR if that's easier for any reason!

@rcskosir
Copy link
Contributor

@ChandlerSwift Thanks for helping us find this accidental close. GitHub is showing that there has been a force-push or recreation on the main branch and will not allow me to reopen this issue. If you could open a new PR that would be greatly appreciated!

@ChandlerSwift
Copy link
Contributor Author

ChandlerSwift commented Jan 19, 2024

@rcskosir Thanks for trying! I've opened #24571; hopefully that'll work.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform plan/apply fail for Azure China Cloud with: "Error ensuring Resource Providers are registered"
3 participants