`azurerm_container_app` - Add `key_vault_id` and `identity` for `secret` nested block. #24773

lonegunmanb · 2024-02-05T05:52:08Z

We've received a feature request here, container app now supports reference key vault secret via url now.

This pull request added support for key_vault_url and identity_id for secret nested block. I found that once a secret block was added with key_vault_url, the value of secret would be returned while read, if we set this secret value back to the state then we'll have a configuration drift. So this pr set secret's value to empty string when key_vault_url is not empty in the response.

Because only absolute attribute paths, ones starting with top level attribute names, are supported by the ConflictsWith, attribute paths cannot be accurately declared for TypeList (if MaxItems is greater than 1), TypeMap, or TypeSet attributes, this pr didn't declare ConflictsWith, but check whether users have set both of key_vault_url and value in Creat and Update methods.

tombuildsstuff · 2024-02-05T06:04:55Z

internal/services/containerapps/helpers/container_apps.go

+				"key_vault_url": {
+					Type:         pluginsdk.TypeString,
+					Optional:     true,
+					ValidateFunc: validation.IsURLWithHTTPS,


can we validate that this is a Key Vault Nested Item, since we don't support Managed HSM Nested Items in the provider at this time?

lonegunmanb · 2024-02-05T09:47:14Z

Hi @tombuildsstuff thanks for the review, I've added a new validator to ensure that it's an url for key vault key, all validate dns suffixes could be found here, and I've also added an unit test to check this rule. Would you please give this pr another review? Thanks!

GurliGebis · 2024-02-05T12:58:00Z

Isn't this a duplicate of #23958 ?

lonegunmanb · 2024-02-06T00:39:07Z

@GurliGebis thanks for the tip, I've also found that #23958's author @x-delfino will not be able to continue that pr for a while, I'd like to continue his work via this pr. I'll try to rebase this pr to his branch and try again.

…cret_id, added validation for MI

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>

lonegunmanb · 2024-02-06T08:51:13Z

Hi @jackofallops @tombuildsstuff @magodo since @x-delfino doesn't have enough bandwidth to continue #23958, I've:

Rebase his branch with the latest main branch
Ensure that the 2 new acc tests passed

Would you please give this pr a review? Thanks!

GurliGebis · 2024-02-06T08:53:13Z

@lonegunmanb have you looked at the reviews done to the other PR? (I think there where some changes in there, that is needed - so would make good sense to include them here)

lonegunmanb · 2024-02-06T09:19:51Z

@lonegunmanb have you looked at the reviews done to the other PR? (I think there where some changes in there, that is needed - so would make good sense to include them here)

Yes, I've read comments left by @magodo and @jackofallops . Now this pr followed what @x-delfino left behind (I think his approach was very close to a success)

falsadoo · 2024-02-12T12:59:36Z

Hi all what is the status on this pull request? We have project that we need this feature.

stephybun

Thanks for picking this up @lonegunmanb. I left some suggestions and questions based off of the review left in #23958. Could you please take a look?

stephybun · 2024-03-07T11:04:34Z

internal/services/containerapps/helpers/container_apps.go

+func validateContainerSecret(s Secret) error {
+	if s.KeyVaultSecretId != "" && s.Identity == "" {
+		return fmt.Errorf("must supply identity for key vault secret id")
+	}
+	if s.KeyVaultSecretId == "" && s.Identity != "" {
+		return fmt.Errorf("must supply key vault secret id when specifying identity")
+	}
+	return nil
+}


As mentioned by another reviewer over in #23958, is there a reason this can't be replaced by setting RequiredWith on the properties in the schema?

We can't use RequiredWith because secret is a Set. I've moved the validation logic into CustomizeDiff. @stephybun

website/docs/d/container_app.html.markdown

website/docs/r/container_app.html.markdown

falsadoo · 2024-03-14T12:03:23Z

@lonegunmanb can you review the comments for this? We really need feature for our project

lonegunmanb · 2024-03-18T07:33:59Z

@stephybun I've updated the pr as you suggested and ran the tests, would you please give this pr another review? Thanks!:

=== RUN TestAccContainerAppResource_basic
=== PAUSE TestAccContainerAppResource_basic
=== CONT TestAccContainerAppResource_basic
--- PASS: TestAccContainerAppResource_basic (591.41s)
=== RUN TestAccContainerAppResource_workloadProfile
=== PAUSE TestAccContainerAppResource_workloadProfile
=== CONT TestAccContainerAppResource_workloadProfile
--- PASS: TestAccContainerAppResource_workloadProfile (1844.85s)
=== RUN TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations
=== PAUSE TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations
=== CONT TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations
--- PASS: TestAccContainerAppResource_smallerGranularityCPUMemoryCombinations (2079.20s)
=== RUN TestAccContainerAppResource_workloadProfileUpdate
=== PAUSE TestAccContainerAppResource_workloadProfileUpdate
=== CONT TestAccContainerAppResource_workloadProfileUpdate
--- PASS: TestAccContainerAppResource_workloadProfileUpdate (3340.86s)
=== RUN TestAccContainerAppResource_withSystemAssignedIdentity
=== PAUSE TestAccContainerAppResource_withSystemAssignedIdentity
=== CONT TestAccContainerAppResource_withSystemAssignedIdentity
--- PASS: TestAccContainerAppResource_withSystemAssignedIdentity (743.44s)
=== RUN TestAccContainerAppResource_withUserAssignedIdentity
=== PAUSE TestAccContainerAppResource_withUserAssignedIdentity
=== CONT TestAccContainerAppResource_withUserAssignedIdentity
--- PASS: TestAccContainerAppResource_withUserAssignedIdentity (646.38s)
=== RUN TestAccContainerAppResource_withSystemAndUserAssignedIdentity
=== PAUSE TestAccContainerAppResource_withSystemAndUserAssignedIdentity
=== CONT TestAccContainerAppResource_withSystemAndUserAssignedIdentity
--- PASS: TestAccContainerAppResource_withSystemAndUserAssignedIdentity (737.31s)
=== RUN TestAccContainerAppResource_withIdentityUpdate
=== PAUSE TestAccContainerAppResource_withIdentityUpdate
=== CONT TestAccContainerAppResource_withIdentityUpdate
--- PASS: TestAccContainerAppResource_withIdentityUpdate (1492.30s)
=== RUN TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate
=== PAUSE TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate
=== CONT TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate
--- PASS: TestAccContainerAppResource_withKeyVaultSecretVersioningUpdate (882.54s)
=== RUN TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate
=== PAUSE TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate
=== CONT TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate
--- PASS: TestAccContainerAppResource_withKeyVaultSecretIdentityUpdate (1339.02s)
=== RUN TestAccContainerAppResource_basicUpdate
=== PAUSE TestAccContainerAppResource_basicUpdate
=== CONT TestAccContainerAppResource_basicUpdate
--- PASS: TestAccContainerAppResource_basicUpdate (781.08s)
=== RUN TestAccContainerAppResource_requiresImport
=== PAUSE TestAccContainerAppResource_requiresImport
=== CONT TestAccContainerAppResource_requiresImport
--- PASS: TestAccContainerAppResource_requiresImport (598.95s)
=== RUN TestAccContainerAppResource_complete
=== PAUSE TestAccContainerAppResource_complete
=== CONT TestAccContainerAppResource_complete
--- PASS: TestAccContainerAppResource_complete (693.93s)
=== RUN TestAccContainerAppResource_completeVolumeEmptyDir
=== PAUSE TestAccContainerAppResource_completeVolumeEmptyDir
=== CONT TestAccContainerAppResource_completeVolumeEmptyDir
--- PASS: TestAccContainerAppResource_completeVolumeEmptyDir (754.19s)
=== RUN TestAccContainerAppResource_completeWithNoDaprAppPort
=== PAUSE TestAccContainerAppResource_completeWithNoDaprAppPort
=== CONT TestAccContainerAppResource_completeWithNoDaprAppPort
--- PASS: TestAccContainerAppResource_completeWithNoDaprAppPort (717.00s)
=== RUN TestAccContainerAppResource_completeWithVNet
=== PAUSE TestAccContainerAppResource_completeWithVNet
=== CONT TestAccContainerAppResource_completeWithVNet
--- PASS: TestAccContainerAppResource_completeWithVNet (1222.30s)
=== RUN TestAccContainerAppResource_completeWithSidecar
=== PAUSE TestAccContainerAppResource_completeWithSidecar
=== CONT TestAccContainerAppResource_completeWithSidecar
--- PASS: TestAccContainerAppResource_completeWithSidecar (739.71s)
=== RUN TestAccContainerAppResource_completeWithMultipleContainers
=== PAUSE TestAccContainerAppResource_completeWithMultipleContainers
=== CONT TestAccContainerAppResource_completeWithMultipleContainers
--- PASS: TestAccContainerAppResource_completeWithMultipleContainers (713.56s)
=== RUN TestAccContainerAppResource_completeUpdate
=== PAUSE TestAccContainerAppResource_completeUpdate
=== CONT TestAccContainerAppResource_completeUpdate
--- PASS: TestAccContainerAppResource_completeUpdate (815.53s)
=== RUN TestAccContainerAppResource_completeTcpExposedPort
=== PAUSE TestAccContainerAppResource_completeTcpExposedPort
=== CONT TestAccContainerAppResource_completeTcpExposedPort
--- PASS: TestAccContainerAppResource_completeTcpExposedPort (1203.16s)
=== RUN TestAccContainerAppResource_removeDaprAppPort
=== PAUSE TestAccContainerAppResource_removeDaprAppPort
=== CONT TestAccContainerAppResource_removeDaprAppPort
--- PASS: TestAccContainerAppResource_removeDaprAppPort (807.73s)
=== RUN TestAccContainerAppResource_secretFail
=== PAUSE TestAccContainerAppResource_secretFail
=== CONT TestAccContainerAppResource_secretFail
--- PASS: TestAccContainerAppResource_secretFail (727.38s)
=== RUN TestAccContainerAppResource_scaleRules
=== PAUSE TestAccContainerAppResource_scaleRules
=== CONT TestAccContainerAppResource_scaleRules
--- PASS: TestAccContainerAppResource_scaleRules (653.58s)
=== RUN TestAccContainerAppResource_multipleScaleRules
=== PAUSE TestAccContainerAppResource_multipleScaleRules
=== CONT TestAccContainerAppResource_multipleScaleRules
--- PASS: TestAccContainerAppResource_multipleScaleRules (690.53s)
=== RUN TestAccContainerAppResource_scaleRulesUpdate
=== PAUSE TestAccContainerAppResource_scaleRulesUpdate
=== CONT TestAccContainerAppResource_scaleRulesUpdate
--- PASS: TestAccContainerAppResource_scaleRulesUpdate (871.02s)
=== RUN TestAccContainerAppResource_ipSecurityRulesUpdate
=== PAUSE TestAccContainerAppResource_ipSecurityRulesUpdate
=== CONT TestAccContainerAppResource_ipSecurityRulesUpdate
--- PASS: TestAccContainerAppResource_ipSecurityRulesUpdate (915.85s)
=== RUN TestAccContainerAppResource_ingressTrafficValidation
=== PAUSE TestAccContainerAppResource_ingressTrafficValidation
=== CONT TestAccContainerAppResource_ingressTrafficValidation
--- PASS: TestAccContainerAppResource_ingressTrafficValidation (14.25s)
PASS

lonegunmanb · 2024-03-18T07:35:47Z

@lonegunmanb can you review the comments for this? We really need feature for our project

@falsadoo sorry for the late update, I think the latest try would pass the review. Thanks for asking.

stephybun

Thanks @lonegunmanb LGTM 🦆

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.97.1" to "3.98.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.98.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.98.0
FEATURES:

* New Resource: `azurerm_static_web_app_function_app_registration` ([#25331](https://github.com/hashicorp/terraform-provider-azurerm/issues/25331))
* New Resource: `azurerm_system_center_virtual_machine_manager_inventory_items` ([#25110](https://github.com/hashicorp/terraform-provider-azurerm/issues/25110))
* New Resource: `azurerm_workloads_sap_discovery_virtual_instance` ([#24342](https://github.com/hashicorp/terraform-provider-azurerm/issues/24342))
* New Resource: `azurerm_redis_cache_policy` ([#25477](https://github.com/hashicorp/terraform-provider-azurerm/issues/25477))
* New Resource: `azurerm_redis_cache_policy_assignment` ([#25477](https://github.com/hashicorp/terraform-provider-azurerm/issues/25477))

ENHANCEMENTS:

* dependencies: updating to `v0.20240402.1085733` of `github.com/hashicorp/go-azure-sdk` ([#25482](https://github.com/hashicorp/terraform-provider-azurerm/issues/25482))
* dependencies: updating to `v0.67.0` of `github.com/hashicorp/go-azure-helpers` ([#25446](https://github.com/hashicorp/terraform-provider-azurerm/issues/25446))
* dependencies: updating to `v0.25.4` of `github.com/tombuildsstuff/giovanni` ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `alertsmanagement` - updating remaining resources to use `hashicorp/go-azure-sdk` ([#25486](https://github.com/hashicorp/terraform-provider-azurerm/issues/25486))
* `applicationinsights` - updating remaining resources to use `hashicorp/go-azure-sdk` ([#25376](https://github.com/hashicorp/terraform-provider-azurerm/issues/25376))
* `compute` - update to API version `2024-03-01` ([#25436](https://github.com/hashicorp/terraform-provider-azurerm/issues/25436))
* `compute` - update shared image resources and data sources to use `hashicorp/go-azure-sdk` ([#25503](https://github.com/hashicorp/terraform-provider-azurerm/issues/25503))
* `containerinstance` - update to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#25416](https://github.com/hashicorp/terraform-provider-azurerm/issues/25416))
* `maintenance` - updating to API Version `2023-04-01` ([#25388](https://github.com/hashicorp/terraform-provider-azurerm/issues/25388))
* `recovery_services` - Add `recovery_service` block to the provider that supports `vm_backup_stop_protection_and_retain_data_on_destroy` and `purge_protected_items_from_vault_on_destroy`([#25515](https://github.com/hashicorp/terraform-provider-azurerm/issues/25515))
* `storage` - the Storage Account cache is now populated using `hashicorp/go-azure-sdk` ([#25437](https://github.com/hashicorp/terraform-provider-azurerm/issues/25437))
* `azurerm_bot_service_azure_bot` - support for the `cmk_key_vault_key_url` property ([#23640](https://github.com/hashicorp/terraform-provider-azurerm/issues/23640))
* `azurerm_capacity_reservation` - update validation for `capacity` ([#25471](https://github.com/hashicorp/terraform-provider-azurerm/issues/25471))
* `azurerm_container_app` - add support for `key_vault_id` and `identity` properties in the `secret` block ([#24773](https://github.com/hashicorp/terraform-provider-azurerm/issues/24773))
* `azurerm_databricks_workspace` - expose `managed_services_cmk_key_vault_id` and `managed_disk_cmk_key_vault_id and key_vault_id` to support cross subscription CMK's. ([#25091](https://github.com/hashicorp/terraform-provider-azurerm/issues/25091))
* `azurerm_databricks_workspace_root_dbfs_customer_managed_key` - expose `key_vault_id` to support cross subscription CMK's. ([#25091](https://github.com/hashicorp/terraform-provider-azurerm/issues/25091))
* `azurerm_managed_hsm_role_*_ids` - use specific resource id to replace generic nested item id ([#25323](https://github.com/hashicorp/terraform-provider-azurerm/issues/25323))
* `azurerm_mssql_database` - add support for `secondary_type` ([#25360](https://github.com/hashicorp/terraform-provider-azurerm/issues/25360))
* `azurerm_monitor_scheduled_query_rules_alert_v2` - support for the `identity` block ([#25365](https://github.com/hashicorp/terraform-provider-azurerm/issues/25365))
* `azurerm_mssql_server_extended_auditing_policy` - support for `audit_actions_and_groups` and `predicate_expression` ([#25425](https://github.com/hashicorp/terraform-provider-azurerm/issues/25425))
* `azurerm_netapp_account` - can now be imported ([#25384](https://github.com/hashicorp/terraform-provider-azurerm/issues/25384))
* `azurerm_netapp_volume` - support for the `kerberos_enabled`, `smb_continuous_availability_enabled`, `kerberos_5_read_only_enabled`, `kerberos_5_read_write_enabled`, `kerberos_5i_read_only_enabled`, `kerberos_5i_read_write_enabled`, `kerberos_5p_read_only_enabled`, and `kerberos_5p_read_write_enabled` properties ([#25385](https://github.com/hashicorp/terraform-provider-azurerm/issues/25385))
* `azurerm_recovery_services_vault` - upgrading to version `2024-01-01` ([#25325](https://github.com/hashicorp/terraform-provider-azurerm/issues/25325))
* `azurerm_stack_hci_cluster` - the `client_id` property is now optional ([#25407](https://github.com/hashicorp/terraform-provider-azurerm/issues/25407))
* `azurerm_storage_encryption_scope` - refactoring to use `hashicorp/go-azure-sdk` rather than `Azure/azure-sdk-for-go` ([#25437](https://github.com/hashicorp/terraform-provider-azurerm/issues/25437))
* `azurerm_mssql_elasticpool` - the `maintenance_configuration_name` property now supports values `SQL_SouthAfricaNorth_DB_1`, `SQL_SouthAfricaNorth_DB_2`, `SQL_WestUS3_DB_1` and `SQL_WestUS3_DB_2` ([#25500](https://github.com/hashicorp/terraform-provider-azurerm/issues/25500))
* `azurerm_lighthouse_assignment` - updating API Version from `2019-06-01` to `2022-10-01` ([#25473](https://github.com/hashicorp/terraform-provider-azurerm/issues/25473))

BUG FIXES:

* `network` - updating the `GatewaySubnet` validation to show the Subnet Name when the validation fails ([#25484](https://github.com/hashicorp/terraform-provider-azurerm/issues/25484))
* `azurerm_function_app_hybrid_connection` - fix an issue during creation when `send_key_name` is specified ([#25379](https://github.com/hashicorp/terraform-provider-azurerm/issues/25379))
* `azurerm_linux_web_app_slot` - fix a crash when upgrading the provider to v3.88.0 or later ([#25406](https://github.com/hashicorp/terraform-provider-azurerm/issues/25406))
* `azurerm_mssql_database` - update the behavior of the `enclave_type` field. ([#25508](https://github.com/hashicorp/terraform-provider-azurerm/issues/25508))
* `azurerm_mssql_elasticpool` - update the behavior of the `enclave_type` field. ([#25508](https://github.com/hashicorp/terraform-provider-azurerm/issues/25508))
* `azurerm_network_manager_deployment` - add locking ([#25368](https://github.com/hashicorp/terraform-provider-azurerm/issues/25368))
* `azurerm_resource_group_template_deployment` - changes to `parameters_content` and `template_content` now force `output_content` to be updated in the plan ([#25403](https://github.com/hashicorp/terraform-provider-azurerm/issues/25403))
* `azurerm_storage_blob` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_container` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_data_lake_gen2_filesystem` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_data_lake_gen2_filesystem_path` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_queue` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_share` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_share_directory` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_share_directory` - resolve an issue where directories might fail to destroy ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_share_file` - fix a potential crash when the endpoint is unreachable ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_storage_share_file` - fix several bugs with path handling when creating files in subdirectories ([#25404](https://github.com/hashicorp/terraform-provider-azurerm/issues/25404))
* `azurerm_web_app_hybrid_connection` - fix an issue during creation when `send_key_name` is specified ([#25379](https://github.com/hashicorp/terraform-provider-azurerm/issues/25379))
* `azurerm_windows_web_app` - prevent a panic during resource upgrade ([#25509](https://github.com/hashicorp/terraform-provider-azurerm/issues/25509))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/88/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

github-actions · 2024-05-03T02:09:13Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added documentation service/container-apps size/L waiting-response labels Feb 5, 2024

tombuildsstuff reviewed Feb 5, 2024

View reviewed changes

github-actions bot removed the waiting-response label Feb 5, 2024

x-delfino and others added 8 commits February 6, 2024 10:41

adding keyvault secret reference support for container apps

4675747

removing erroneous newline

e848760

updating primitive behaviours, secrets to list, renaming key_vault_se…

1d0a76b

…cret_id, added validation for MI

adding docs, updating tests, fixing secret data schemas

5faa1d8

fixing dapr secrets schema

908bac5

Update container app secret identity 'System' case sensitivity

511fedc

Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>

reverting to set. dont store kv secret value

bddecb3

fix test

737d373

lonegunmanb force-pushed the container-app-secret-key-vault-url branch from 5e32e56 to 737d373 Compare February 6, 2024 08:26

github-actions bot added size/XL and removed size/L labels Feb 6, 2024

lonegunmanb changed the title ~~azurerm_container_app - Add key_vault_url and identity_id for secret nested block.~~ azurerm_container_app - Add key_vault_id and identity for secret nested block. Feb 6, 2024

fix format issue

5000196

This was linked to issues Feb 6, 2024

Support for Key Vault integration with Container Apps Secrets #23668

Closed

Support for key vault reference secrets in container apps #21739

Closed

katbyte assigned jackofallops Feb 27, 2024

GurliGebis mentioned this pull request Feb 27, 2024

azurerm_container_app add support for key vault secret references as secret #23958

Closed

stephybun requested changes Mar 7, 2024

View reviewed changes

github-actions bot added the waiting-response label Mar 7, 2024

adjust document as review suggested

902df54

update as code review suggested

1007c8a

github-actions bot removed the waiting-response label Mar 18, 2024

lonegunmanb requested review from tombuildsstuff and stephybun March 18, 2024 07:30

stephybun assigned stephybun and unassigned jackofallops Mar 28, 2024

stephybun approved these changes Apr 2, 2024

View reviewed changes

stephybun added the enhancement label Apr 2, 2024

stephybun merged commit a4a8228 into hashicorp:main Apr 2, 2024
34 checks passed

github-actions bot added this to the v3.98.0 milestone Apr 2, 2024

stephybun added a commit that referenced this pull request Apr 2, 2024

Update for #24773 #25482

561f2fd

dhduvall mentioned this pull request May 1, 2024

Unknown properties key_vault_secret_id in Microsoft.ContainerApps.WebApi.Views.Version20230501.ContainerAppSecretView are not supported #25820

Closed

1 task

github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_container_app` - Add `key_vault_id` and `identity` for `secret` nested block. #24773

`azurerm_container_app` - Add `key_vault_id` and `identity` for `secret` nested block. #24773

lonegunmanb commented Feb 5, 2024

tombuildsstuff Feb 5, 2024

lonegunmanb commented Feb 5, 2024

GurliGebis commented Feb 5, 2024

lonegunmanb commented Feb 6, 2024

lonegunmanb commented Feb 6, 2024

GurliGebis commented Feb 6, 2024

lonegunmanb commented Feb 6, 2024

falsadoo commented Feb 12, 2024

stephybun left a comment

stephybun Mar 7, 2024

lonegunmanb Mar 18, 2024 •

edited

falsadoo commented Mar 14, 2024 •

edited

lonegunmanb commented Mar 18, 2024

lonegunmanb commented Mar 18, 2024

stephybun left a comment

github-actions bot commented May 3, 2024

azurerm_container_app - Add key_vault_id and identity for secret nested block. #24773

azurerm_container_app - Add key_vault_id and identity for secret nested block. #24773

Conversation

lonegunmanb commented Feb 5, 2024

tombuildsstuff Feb 5, 2024

Choose a reason for hiding this comment

lonegunmanb commented Feb 5, 2024

GurliGebis commented Feb 5, 2024

lonegunmanb commented Feb 6, 2024

lonegunmanb commented Feb 6, 2024

GurliGebis commented Feb 6, 2024

lonegunmanb commented Feb 6, 2024

falsadoo commented Feb 12, 2024

stephybun left a comment

Choose a reason for hiding this comment

stephybun Mar 7, 2024

Choose a reason for hiding this comment

lonegunmanb Mar 18, 2024 • edited

Choose a reason for hiding this comment

falsadoo commented Mar 14, 2024 • edited

lonegunmanb commented Mar 18, 2024

lonegunmanb commented Mar 18, 2024

stephybun left a comment

Choose a reason for hiding this comment

github-actions bot commented May 3, 2024

`azurerm_container_app` - Add `key_vault_id` and `identity` for `secret` nested block. #24773

`azurerm_container_app` - Add `key_vault_id` and `identity` for `secret` nested block. #24773

lonegunmanb Mar 18, 2024 •

edited

falsadoo commented Mar 14, 2024 •

edited