Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

managed_hsm_*: add managed hsm nested key ids #25324

Closed
wants to merge 3 commits into from
Closed

managed_hsm_*: add managed hsm nested key ids #25324

wants to merge 3 commits into from

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Mar 20, 2024 •
edited
Loading

Dependent on hashicorp/go-azure-helpers#222.

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

add the managed hsm key id which is required by #25069 and other places.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

tombuildsstuff
tombuildsstuff reviewed Mar 20, 2024
View reviewed changes
internal/services/managedhsm/resourceids.go Outdated
Comment on lines 1 to 7
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: MPL-2.0

package managedhsm

//go:generate go run ../../tools/generator-resource-id/main.go -path=./ -name=ManagedHSMNestedKeyWithVersion -id=/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.KeyVault/managedHSMs/mhsm1/keys/key1/versions/version1
//go:generate go run ../../tools/generator-resource-id/main.go -path=./ -name=ManagedHSMNestedKeyVersionless -id=/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.KeyVault/managedHSMs/mhsm1/keys/key1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The legacy Resource ID generator shouldn't be used for new Resources going forwards - can we instead update these to use the new Resource ID interface that hashicorp/go-azure-sdk etc uses?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also shouldn't these be the Data Plane IDs rather than the Resource Manager IDs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the parser of the new resource ID cannot suuport the Data Plane ID like https://hsm-name.managedhsm.azure.net/keys/key-name/version. I'd like to create a PR to support it. Also we have to keep this reosurce manager ID for some other resource may reference to a ARM ID instead of the data plane id. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a PR to make the new resource id parser support data plane id: hashicorp/go-azure-helpers#222

@Botje Botje mentioned this pull request Mar 22, 2024
Merged
@rcskosir
Copy link
Contributor

@wuxu92 👋 Thanks for using our new PR template and including a description! Can you please update it to include an accurate changelog portion and check the appropriate boxes for this PR? This helps with the review process and also future users understanding of what is happening in this PR. Thanks!

@katbyte
Copy link
Collaborator

katbyte commented Mar 26, 2024

@wuxu92 we have a ton of CI failures?

@wuxu92
Copy link
Contributor Author

wuxu92 commented Mar 26, 2024

@katbyte The PR is dependent on hashicorp/go-azure-helpers#222, and I am going to convert this PR to draft...

@wuxu92 wuxu92 mentioned this pull request Mar 26, 2024
Closed
@wuxu92 wuxu92 marked this pull request as draft March 26, 2024 05:15
@tombuildsstuff tombuildsstuff self-assigned this Apr 4, 2024
@tombuildsstuff
Copy link
Member

hey @wuxu92

Thanks for this PR - taking a look through here there's already an existing Resource Manager ID parser within hashicorp/go-azure-sdk (which we should probably promote to be a Common ID - I've opened hashicorp/go-azure-helpers#230 to track that for the future) - and as such this wants to focus on the Data Plane component instead.

I've ended up digging into this and have discovered that we want to take a different approach than the one used here, since this'll also end up being used for Key Vault in the future too - and as such I hope you don't mind but I'm going to close this PR in favour of #25601 which implements the Data Plane specific Resource ID parsers.

Thanks!

@katbyte
Copy link
Collaborator

katbyte commented May 7, 2024

superceeded by #25601

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

Assignees

@tombuildsstuff tombuildsstuff

Labels
dependencies service/managed-hsm size/XL waiting-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wuxu92 @rcskosir @katbyte @tombuildsstuff