Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/resource: azurerm_management_group - now exports tenant_scoped_id #25555

Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -71,7 +71,7 @@ func resourceEventGridSystemTopic() *pluginsdk.Resource {
ForceNew: true,
ValidateFunc: validation.Any(
azure.ValidateResourceID,
mgmtGroupValidate.ManagementGroupID,
mgmtGroupValidate.ManagementGroupIDForSystemTopic,
BrendanThompson marked this conversation as resolved.
Show resolved Hide resolved
),
},

Expand Down
27 changes: 27 additions & 0 deletions internal/services/managementgroup/parse/management_group.go
Expand Up @@ -40,6 +40,33 @@ func ManagementGroupID(input string) (*ManagementGroupId, error) {
return &id, nil
}

func ManagementGroupIDForSystemTopic(input string) (*ManagementGroupId, error) {
regex := regexp.MustCompile(`^/tenants/.+/providers/[Mm]icrosoft\.[Mm]anagement/[Mm]anagement[Gg]roups/`)
if !regex.MatchString(input) {
return nil, fmt.Errorf("Unable to parse Management Group ID for System Topic %q, format should look like '/tenants/<tenantID>/providers/Microsoft.Management/managementGroups/<management_group_name>'", input)
}

// Split the input ID by the regex
segments := regex.Split(input, -1)
if len(segments) != 2 {
return nil, fmt.Errorf("Unable to parse Management Group ID %q: expected id to have two segments after splitting", input)
}

groupID := segments[1]
if groupID == "" {
return nil, fmt.Errorf("unable to parse Management Group ID %q: management group name is empty", input)
}
if segments := strings.Split(groupID, "/"); len(segments) != 1 {
return nil, fmt.Errorf("unable to parse Management Group ID %q: ID has extra segments", input)
}

id := ManagementGroupId{
Name: groupID,
}

return &id, nil
}

func NewManagementGroupId(managementGroupName string) ManagementGroupId {
return ManagementGroupId{
Name: managementGroupName,
Expand Down
15 changes: 15 additions & 0 deletions internal/services/managementgroup/validate/management_group_id.go
Expand Up @@ -23,3 +23,18 @@ func ManagementGroupID(i interface{}, k string) (warnings []string, errors []err

return
}

func ManagementGroupIDForSystemTopic(i interface{}, k string) (warnings []string, errors []error) {
v, ok := i.(string)
if !ok {
errors = append(errors, fmt.Errorf("expected type of %q to be string", k))
return
}

if _, err := parse.ManagementGroupIDForSystemTopic(v); err != nil {
errors = append(errors, fmt.Errorf("Can not parse %q as a management group id: %v", k, err))
return
}

return
}