Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managedhsm: introducing dedicated Resource ID Parsers for the Data Plane Versioned and Versionless Key IDs #25601

Merged
merged 24 commits into from
May 2, 2024

Commits on Apr 19, 2024

  1. managedhsm: introducing dedicated Resource ID Parsers for the Data Pl…

    …ane Versioned and Versionless Key IDs
    tombuildsstuff committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    b3fa4ee View commit details
    Browse the repository at this point in the history
  2. managedhsms: updating the Resource ID parser for Managed HSM Role A…

    …ssignment
    
    This switches to using the Resource ID the Resource actually uses rather than this apparent Terraform unique value?
    tombuildsstuff committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    b1cd355 View commit details
    Browse the repository at this point in the history
  3. managedhsm: refactoring the Managed HSM Role Assignment Resource

    This now uses `managed_hsm_id` to discover the Managed HSM rather than the Data Plane URI - which mirrors the pattern used elsewhere.
    This is important for two reasons:
    
    1. We don't support provisioning resources across Subscriptions - a unique Provider instance needs to be used for each Subscription
    2. This allows us to determine when the Managed HSM in question has been removed out-of-band due to limitations in Go's networking layer
    tombuildsstuff committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    696c135 View commit details
    Browse the repository at this point in the history
  4. managedhsm: updating the Parser tests/adding extra tests covering t…

    …he Parse function directly
    
    This was tested via the validate, but was missing tests covering this directly
    tombuildsstuff committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    45644a6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    64511e3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a4f5003 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    302f5ea View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3b1760e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c9dfeab View commit details
    Browse the repository at this point in the history
  10. imports

    tombuildsstuff committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    34b033f View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    d6ac8e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c922a0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a3a4fb5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5839d0a View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. managedhsm: don't trim the scope when outputting role definition/assi…

    …gnment IDs
    
    This causes "/" to become "", and "/keys" to become "keys"
    
    We only trim the first leading slash when parsing, not when outputting.
    manicminer committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ff65294 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    759df85 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ce56bbe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    301fd04 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bd9873c View commit details
    Browse the repository at this point in the history
  6. linting

    manicminer committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f23428e View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Configuration menu
    Copy the full SHA
    553c0a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    204e3e8 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Configuration menu
    Copy the full SHA
    f1337c1 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. remove check

    katbyte committed May 2, 2024
    Configuration menu
    Copy the full SHA
    bdb8162 View commit details
    Browse the repository at this point in the history