Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore azurerm_nginx_configuration resource and data source #25740

Closed
wants to merge 3 commits into from

Conversation

valyria257
Copy link
Contributor

Reverts #24276

There are a couple of things here:

  • The default configuration/import error issue was resolved. See changelog from March 13, 2024
  • This is a breaking change from a product use-case perspective as it breaks our HTTPS use-case where in the workflow is:
    1. Create deployment.
    2. Create certificate.
    3. Create configuration.

With configuration now being inline, the use workflow breaks as 1 and 3 cannot be separated.

  • certificates should also not be inline since different roles may mange deployments, certificates, and configurations separately

To fix this, the change to remove the azurerm_nginx_configuration is reverted, and the field that was added to replace it is deprecated.

@stephybun
Copy link
Member

Duplicate of #25402

@stephybun stephybun marked this as a duplicate of #25402 Apr 26, 2024
@stephybun stephybun closed this Apr 26, 2024
@valyria257
Copy link
Contributor Author

@stephybun this PR supersedes #25402. Can you please reopen? cc: @puneetsarna

@puneetsarna
Copy link
Contributor

@stephybun I am going to close mine. @valyria257 has changes that we need to deprecate the newer embedded fields and a test to establish the contract as well in addition to the restoration of the resource.

@valyria257
Copy link
Contributor Author

Created a new PR instead: #25773

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants