Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore azurerm_nginx_configuration resource and data source #25740

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions internal/services/nginx/nginx_configuration_data_source_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// Copyright (c) HashiCorp, Inc.
// SPDX-License-Identifier: MPL-2.0

package nginx_test

import (
"fmt"
"testing"

"github.com/hashicorp/terraform-provider-azurerm/internal/acceptance"
"github.com/hashicorp/terraform-provider-azurerm/internal/acceptance/check"
)

type NginxConfigurationDataSource struct{}

func TestAccNginxConfigurationDataSource_basic(t *testing.T) {
data := acceptance.BuildTestData(t, "data.azurerm_nginx_configuration", "test")
r := NginxConfigurationDataSource{}

data.DataSourceTest(t, []acceptance.TestStep{
{
Config: r.basic(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).Key("root_file").Exists(),
check.That(data.ResourceName).Key("config_file").Exists(),
),
},
})
}

func (d NginxConfigurationDataSource) basic(data acceptance.TestData) string {
return fmt.Sprintf(`
%s

data "azurerm_nginx_configuration" "test" {
nginx_deployment_id = azurerm_nginx_deployment.test.id
}
`, ConfigurationResource{}.basic(data))
}
8 changes: 0 additions & 8 deletions internal/services/nginx/nginx_configuration_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,7 @@ func (c ConfigurationModel) ToSDKModel() nginxconfiguration.NginxConfiguration {

type ConfigurationResource struct{}

// This resource has been deprecated and will be removed in the next major release.
// Default Nginx Configuration cannot be created anymore for service API breaking change created it automatically
// nginx configuration block is now embedded into nginx deployment resource
func (m *ConfigurationResource) DeprecatedInFavourOfResource() string {
return "azurerm_nginx_deployment"
}

var _ sdk.Resource = (*ConfigurationResource)(nil)
var _ sdk.ResourceWithDeprecationReplacedBy = &ConfigurationResource{}

func (m ConfigurationResource) Arguments() map[string]*pluginsdk.Schema {
return map[string]*pluginsdk.Schema{
Expand Down
Loading