Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_app_environment - Support for Mutual TLS added #25993

Merged
merged 6 commits into from
May 29, 2024

Conversation

jhisc
Copy link
Contributor

@jhisc jhisc commented May 16, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Adding support for Mutual TLS within Azure Container App Environments.
This is a non breaking change and backwards compatable.

Changes can be made to existing resources without requiring a re-creation.
Defaults to false which results in a no-changes to existing infrastructure.

Provider tested to validate:

  • New Resources created with MTLS enabled and disabled
  • Updating existing resource to Enable/Disable MTLS
  • State Refresh where changes made outside of Terraform

Feature enhancement - Not a major chance, optional input
PR looks worse than it is, vast majority of changed files are the new SDK version being pulled into the Vendor folder.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • [] I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

I have been unable to execute the tests locally, however conducted manual testing with the new provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Resolves #21960

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhisc 0- overall looks good i just have 1 minor comment i've left inline. Once that is addressed i think this is good to merge provided tests pass

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @jhisc! I have two comments/questions on this PR. Would you mind taking a look? Once they're resolved this should be good to go

@jhisc
Copy link
Contributor Author

jhisc commented May 28, 2024

Thanks for this PR @jhisc! I have two comments/questions on this PR. Would you mind taking a look? Once they're resolved this should be good to go

Thanks! Both comments have been resolved 👍

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhisc nearly there, could you rebase your branch on top of main? That should fix the Vendor dependencies check and then we can run the tests.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, thanks @jhisc LGTM 💯

@stephybun stephybun merged commit 9b893ce into hashicorp:main May 29, 2024
33 checks passed
@github-actions github-actions bot added this to the v3.106.0 milestone May 29, 2024
stephybun added a commit that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for mtls in the azurerm_container_app_environment resource
3 participants