Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_data_factory_pipeline #3244

Merged
merged 5 commits into from
Apr 16, 2019
Merged

New Resource: azurerm_data_factory_pipeline #3244

merged 5 commits into from
Apr 16, 2019

Conversation

mbfrahry
Copy link
Member 

--- PASS: TestAccAzureRMDataFactoryPipeline_basic (78.39s)
--- PASS: TestAccAzureRMDataFactoryPipeline_update (97.29s)

katbyte
katbyte approved these changes Apr 15, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some minor comments this LGTM @mbfrahry 👍

azurerm/resource_arm_data_factory_pipeline.go Show resolved Hide resolved
azurerm/resource_arm_data_factory_pipeline.go Outdated Show resolved Hide resolved
azurerm/resource_arm_data_factory_pipeline.go Outdated Show resolved Hide resolved
azurerm/resource_arm_data_factory_pipeline.go Outdated Show resolved Hide resolved
@katbyte katbyte added this to the v1.25.0 milestone Apr 15, 2019
tombuildsstuff
tombuildsstuff approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor things but this otherwise LGTM 👍

azurerm/resource_arm_data_factory_pipeline.go Outdated Show resolved Hide resolved
azurerm/resource_arm_data_factory_pipeline.go Show resolved Hide resolved
azurerm/resource_arm_data_factory_pipeline_test.go Outdated Show resolved Hide resolved
azurerm/resource_arm_data_factory_pipeline_test.go Outdated Show resolved Hide resolved
@mbfrahry mbfrahry merged commit 3f7bbac into master Apr 16, 2019
@mbfrahry mbfrahry deleted the f-datafactory-pipeline branch April 16, 2019 04:16
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 16, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/data-factory size/XL
Projects
None yet
Milestone
v1.25.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbfrahry @tombuildsstuff @katbyte