New resource "azurerm_private_dns_zone_virtual_network_link"

[tiwood]

• New resource "azurerm_private_dns_zone_virtual_network_link"
• Add tests
• Documentation

azurerm_private_dns_zone_virtual_network_link

Enables you to manage Private DNS zone Virtual Network Links. These Links enable DNS resolution and registration inside Azure Virtual Networks using Azure Private DNS.

Example Usage

resource "azurerm_resource_group" "test" {
  name     = "acceptanceTestResourceGroup1"
  location = "West US"
}

resource "azurerm_private_dns_zone" "test" {
  name                = "mydomain.com"
  resource_group_name = "${azurerm_resource_group.test.name}"
}

resource "azurerm_private_dns_zone_virtual_network_link" "test" {
  name                  = "test"
  resource_group_name   = azurerm_resource_group.test.name
  private_dns_zone_name = azurerm_private_dns_zone.test.name
  virtual_network_id    = azurerm_virtual_network.test.id
}

Argument Reference

The following arguments are supported:

• name - (Required) The name of the Private DNS Zone Virtual Network Link. Changing this forces a new resource to be created.

• private_dns_zone_name - (Required) The name of the Private DNS zone (without a terminating dot). Changing this forces a new resource to be created.

• virtual_network_id - (Required) The Resource ID of the Virtual Network that should be linked to the DNS Zone. Changing this forces a new resource to be created.

• registration_enabled - (Optional) Is auto-registration of virtual machine records in the virtual network in the Private DNS zone enabled? Defaults to false.

• resource_group_name - (Required) Specifies the resource group where the resource exists. Changing this forces a new resource to be created.

• tags - (Optional) A mapping of tags to assign to the resource.

TODO

• The resources work as expected (create/update/delete) but tests currently fail - possibly due to Timing/Replication issues.

Fixes #3758

[tiwood]

Closes #3758

[DonEstefan]

I guess this patch should contain some code to deprecate the following arguments of the azurerm_dns_zone resource:

• registration_virtual_network_ids
• resolution_virtual_network_ids
• zone_type

[williamoverton]

Any update on this? Still having to use the deprecated "zone_type" field in the azurerm_dns_zone provider :(

[tombuildsstuff]

hey @tiwood

Thanks for this PR - apologies for the delayed review here, with this being marked as a WIP PR I'd missed this wasn't ready for review - sorry!

Taking a look through this mostly LGTM - if we can fix up the comments then this otherwise should be good to merge; since this looks good so that we can get this merged into the 1.34 release, I hope you don't mind but I'm going to push some commits to fix those comments.

Thanks!

[tombuildsstuff]

Rebased this / fixed up the tests (when running I noticed the Read function called the Private DNS Zone Read function rather than the Virtual Network Link Read; and that the API appears to return that the Virtual Network Link's been deleted before it's actually gone)

[tombuildsstuff]

Tests pass:

Thanks for this @tiwood :)

[ghost]

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!