Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/private_dns_zone: polling on the future instead of sleeping #4307

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

tombuildsstuff
Copy link
Contributor

This PR updates the Private DNS Zone resource to poll until the resource is created using the Future returned from the SDK, rather than sleeping for the specified time period. Also switches to reading properties from the properties block to match the API response.

Noticed whilst reviewing #3789

@tombuildsstuff tombuildsstuff added this to the v1.34.0 milestone Sep 12, 2019
@tombuildsstuff tombuildsstuff requested a review from a team September 12, 2019 12:07
@ghost ghost added the size/S label Sep 12, 2019
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2019-09-12 at 14 30 14

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 30acad4 into master Sep 12, 2019
@tombuildsstuff tombuildsstuff deleted the r/private-dns-zone branch September 12, 2019 15:59
tombuildsstuff added a commit that referenced this pull request Sep 12, 2019
@ghost
Copy link

ghost commented Sep 18, 2019

This has been released in version 1.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants