New Resource: azurerm_windows_virtual_machine_scale_set

[tombuildsstuff]

This PR introduces a new resource azurerm_windows_virtual_machine_scale_set which was previously outlined in #2807 - which is mostly based on #4518 with some Windows specifics.

Support for the new resources coming in 2.0 is intentionally feature-toggled off by default - once the remaining Virtual Machine/Virtual Machine Scale Set resources become available we'll publicise this, but for the moment I've intentionally held off documenting how to opt into this functionality.

Upcoming PR's will add support for the other new Virtual Machine and Virtual Machine Scale Set resources documented in the 2.0 announcement.

Also includes a documentation fix for #4398 which documents a dependency is required on the LB Rule, which is indirectly required.

[tombuildsstuff]

Ignoring some expected test failures (because of the feature not being enabled in our subscription [which I've requested], a bug we're waiting for a release of the SDK for - or will be fixed by #4453) - the tests otherwise look good:

[katbyte]

Aside from a couple minor comments LGTM 👍

[ghost]

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!