Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analysisservices - add ID parsing function #5356

Merged
merged 4 commits into from Jan 12, 2020
Merged

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jan 9, 2020

No description provided.

@katbyte katbyte added this to the v1.41.0 milestone Jan 9, 2020
@ghost ghost added the size/M label Jan 9, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs unit tests but otherwise LGTM 👍

Name string
}

func AnalysisServicesServerID(input string) (*AnalysisServicesServerId, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add unit tests for this parser, similar to the other parsers?

@ghost ghost added size/L and removed size/M labels Jan 12, 2020
@katbyte katbyte merged commit 0539945 into master Jan 12, 2020
@katbyte katbyte deleted the kt/parse-analysis branch January 12, 2020 03:02
@ghost
Copy link

ghost commented Jan 16, 2020

This has been released in version 1.41.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.41.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants