Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bot - add parse ID and function #5692

Closed
wants to merge 4 commits into from
Closed

bot - add parse ID and function #5692

wants to merge 4 commits into from

Conversation

tracypholmes
Copy link
Contributor

No description provided.

@tracypholmes tracypholmes added this to the v1.44.0 milestone Feb 12, 2020
@tracypholmes tracypholmes requested a review from a team February 12, 2020 01:15
@ghost ghost added the size/XXL label Feb 12, 2020
tombuildsstuff
tombuildsstuff requested changes Feb 12, 2020
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments regarding checking the name but this otherwise looks good 👍

azurerm/internal/services/bot/parse/bot_channel_email.go Show resolved Hide resolved
azurerm/internal/services/bot/parse/bot_channel_email.go Show resolved Hide resolved
azurerm/internal/services/bot/parse/bot_channel_email_test.go Outdated Show resolved Hide resolved
azurerm/internal/services/bot/parse/bot_channel_email_test.go Show resolved Hide resolved
azurerm/internal/services/bot/parse/bot_channel_slack.go Show resolved Hide resolved
azurerm/internal/services/bot/parse/bot_channels_registration.go Outdated

type BotChannelsRegistrationId struct {
ResourceGroup string
Name string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(as above)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused on this one? The Name field is already exposed. The other channels are connected to this one, so I shouldn't need BotName correct? 🤔

@tombuildsstuff tombuildsstuff modified the milestones: v1.44.0, v2.0.0 Feb 12, 2020
tracypholmes and others added 3 commits February 12, 2020 09:40
@tracypholmes @tombuildsstuff
Update azurerm/internal/services/bot/parse/bot_channel_email.go
368ce52 
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@tracypholmes @tombuildsstuff
Update azurerm/internal/services/bot/parse/bot_channel_email.go
853ad3a 
Co-Authored-By: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@tracypholmes
addresses code review
fc1a04e
@tracypholmes tracypholmes requested review from tombuildsstuff and a team February 13, 2020 19:20
@tombuildsstuff tombuildsstuff modified the milestones: v2.0.0, v2.1.0 Feb 23, 2020
@katbyte katbyte mentioned this pull request Mar 6, 2020
Merged
@tombuildsstuff tombuildsstuff modified the milestones: v2.1.0, v2.2.0 Mar 10, 2020
@katbyte katbyte modified the milestones: v2.2.0, v2.3.0 Mar 18, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.3.0, v2.5.0 Mar 25, 2020
@tombuildsstuff tombuildsstuff modified the milestones: v2.5.0, v2.7.0 Apr 7, 2020
@katbyte katbyte removed this from the v2.7.0 milestone Apr 7, 2020
@katbyte
Copy link
Collaborator

katbyte commented Apr 7, 2020

Hey @tracypholmes, as this has been inactive for a while i am going to close it. We can re-open it once you're ready for it to be reviewed again 🙂

@katbyte katbyte closed this Apr 7, 2020
@tombuildsstuff tombuildsstuff deleted the tph/parse-bot branch April 17, 2020 07:27
@ghost
Copy link

ghost commented May 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
enhancement service/bots size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tracypholmes @katbyte @tombuildsstuff