Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update r/azurerm_(linux|windows)_virtual_machine_scale_set: add support for automatic instance repair #6346

Merged
merged 3 commits into from
Apr 23, 2020

Conversation

ArcturusZhang
Copy link
Contributor

This PR introduces the automatic instance repairs policy to resource azurerm_linux_virtual_machine_scale_set and azurerm_windows_virtual_machine_scale_set.

Automatic instance repairs policy is currently in public preview, you can find more information about this by this doc

@katbyte katbyte self-assigned this Apr 7, 2020
@katbyte katbyte added enhancement service/vmss Virtual Machine Scale Sets labels Apr 8, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @ArcturusZhang! looks good aside from a couple comments

@ArcturusZhang
Copy link
Contributor Author

Hi @katbyte I have added another step that turns the automatic instance repair on again.
And I spotted I did not follow the step of on -> off -> on in the terminate notification feature, therefore I also included same changes to the terminate notification tests.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArcturusZhang! this LGTM now 🚀

@katbyte katbyte added this to the v2.7.0 milestone Apr 23, 2020
katbyte added a commit that referenced this pull request Apr 23, 2020
@katbyte katbyte merged commit 8dc7eca into hashicorp:master Apr 23, 2020
@ghost
Copy link

ghost commented Apr 23, 2020

This has been released in version 2.7.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.7.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 24, 2020
@ArcturusZhang ArcturusZhang deleted the VMSS-Automatic-Repair branch October 22, 2020 02:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants