Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management - Only set hostname_configuration properties if not empty #6850

Merged
merged 1 commit into from
May 13, 2020

Conversation

sirlatrom
Copy link
Contributor

When the fields are set to empty strings instead of null, the error message in #6621 is given. When set to null when empty strings, the update goes through.

Fixes #6621.

Signed-off-by: Sune Keller <absukl@almbrand.dk>
@schlbra
Copy link

schlbra commented May 11, 2020

Thank you @sirlatrom for your contribution on this bug fix!

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @sirlatrom 👍

@tombuildsstuff tombuildsstuff added this to the v2.10.0 milestone May 12, 2020
@katbyte katbyte changed the title Only set hostname_configuration fields if non-empty azurerm_api_management - Only set hostname_configuration properties if not empty May 13, 2020
@katbyte katbyte merged commit b5a336c into hashicorp:master May 13, 2020
katbyte added a commit that referenced this pull request May 13, 2020
@sirlatrom sirlatrom deleted the fix-6621 branch May 13, 2020 23:52
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants