azurerm_container_registry - support for trust_policy and retention_policy
#8698
Conversation
ghost
added
There was a problem hiding this comment.
Thanks for the pr @notchairmk - overall this looks good but i have some UX concerns around the schema as well as the order of API calls being made. I think it would be less code changes and API calls to do the SKU updates at the same time as before, and then make a separate API call afterwards to update the policies? WDYT? reread PR description and this make sense now 🙂
azurerm/internal/services/containers/container_registry_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/tests/container_registry_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/tests/container_registry_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/tests/container_registry_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/tests/container_registry_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/tests/container_registry_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/tests/container_registry_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/container_registry_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/containers/container_registry_resource.go
Outdated
Show resolved
Hide resolved
|
Updated and all PR comments should have been addressed. Thanks! |
|
This has been released in version 2.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.32.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Adds
policiesblock toazurerm_container_registryfor settingtrust_policyandretention_policy.Azure doesn't support upgrading to Premium SKU and setting attributes specific to Premium SKUs simultaneously. This PR breaks the client update calls into two separate areas.
Closes #8485