Switch the data.dns_txt_record_set test to terraform.io #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the long run we're going to set up a specialized test domain for this so we don't need to keep tweaking for changes to these "real" domains, but this is just a tactical update to get the test passing again.
radeksimko
approved these changes
Feb 28, 2018
There was a problem hiding this comment.
@apparentlymart FYI: We already have a specialised test domain - hashicorptest.com which is managed via CloudFlare.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the long run we're going to set up a specialized test domain for this so we don't need to keep tweaking for changes to these "real" domains, but this is just a tactical update to get the test passing again.