Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resource Service for Apphub #7090

Conversation

modular-magician
Copy link
Collaborator

Add resource for registering identified Service to the Application
FIXES hashicorp/terraform-provider-google#17496

Based on other PR:

  1. Add data source for apphub discovered service GoogleCloudPlatform/magic-modules#10105

Release Note Template for Downstream PRs (will be copied)

google_apphub_service

Derived from GoogleCloudPlatform/magic-modules#10132

* Add new resource for Service Project for Apphub

FIXES hashicorp/terraform-provider-google#17405

* Add new resource for Service Project for Apphub

FIXES hashicorp/terraform-provider-google#17405

* Add new resource for Service Project Attachment for Apphub

FIXES hashicorp/terraform-provider-google#17405

* Add new resource for Service Project Attachment for Apphub

FIXES hashicorp/terraform-provider-google#17405

* Add new resource for Service Project Attachment for Apphub

FIXES hashicorp/terraform-provider-google#17405

* Add new resource for Application for Apphub

* Add new resource for Application for Apphub

* Enable Apphub API in test cases

* Add new resource for Service Project Attachment for Apphub

FIXES hashicorp/terraform-provider-google#17405

* Enable apphub API in test cases

* Fix precheck error

* Fix precheck error

* Fix precheck error

* Fix precheck error

* Resolve comments

* Fix lint error

* Fix errors

* Add new resource for Service for Apphub

* Fix examples

* Add test

* Fix tests

* Add IAM permissions

* Add IAM permission

* Fix IAM issues

* Remove merged changes

* Add billing account

* Remove extra delay from tests

* Add handwritten update test

* Remove merged changes

* Make changes to yaml file incorporating comments from GoogleCloudPlatform/magic-modules#10155

* Fix lint errors in Service YAML definition

* Add a delay between discovered resource fetch and forwarding rule creation

* Add a delay between discovered resource fetch and forwarding rule creation

* Add a delay between discovered resource fetch and forwarding rule creation

* Batch update tests to improve speed

* Use standard diff suppress function

* Update region from us-east1 to us-central1

---------

Co-authored-by: Krishnan Gopal <krishgopal@google.com>
Co-authored-by: praseedhaPK <161299686+praseedhaPK@users.noreply.github.com>

[upstream:4fa7f7c5c43d93b9813acd33ecf232f6cd6151ed]

Signed-off-by: Modular Magician <magic-modules@google.com>
slevenick added a commit that referenced this pull request Mar 18, 2024
Missed due to PR #7090 not being merged automatically
slevenick added a commit that referenced this pull request Mar 18, 2024
* Add missed apphub service release note

Missed due to PR #7090 not being merged automatically

* Update CHANGELOG.md

Co-authored-by: Riley Karson <rileykarson@google.com>

---------

Co-authored-by: Riley Karson <rileykarson@google.com>
@rileykarson
Copy link
Collaborator

Note: This was merged in #7091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants