Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity: update nightly workflow to use static branch #7558

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Jun 18, 2024

applying changes made on terraform-provider-google which allows the ability to use a static branch filter for teamcity triggered builds.

More can be read here: hashicorp/terraform-provider-google#18447

@BBBmau BBBmau requested a review from SarahFrench June 18, 2024 13:42
Copy link

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@github-actions github-actions bot requested a review from shuyama1 June 18, 2024 13:43
@BBBmau BBBmau removed the request for review from shuyama1 June 18, 2024 13:44
Copy link
Member

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please update the comments (or use the suggestions) to describe the two workflows accurately

BBBmau and others added 2 commits June 18, 2024 09:35
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>
@BBBmau BBBmau merged commit be1b880 into hashicorp:main Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants