TeamCity: update nightly workflow to use static branch

[BBBmau]

Continuation of #18241

An issue with TeamCity unable to perform updates on branchFilter spec resulted in the date itself not matching the nightly test branch created.

This is resolved with using a static branch filter (+:UTC-*) within teamcity configs. To make this work we'll create a branch such as UTC-2024-06-24 for use by TeamCity to run the nightly test. Once a considerable period of time has passed, a cronjob will trigger that renames the UTC-2024-06-24 -> UTC-nightly-tests-2024-06-24. The renaming is just for Github and allows us to only focus on one branch which must match both +:UTC-* and -:UTC-nightly-tests-*

The update to the TeamCity branchFilter spec can be seen here: GoogleCloudPlatform/magic-modules#10785

Example run of the new workflows:
teamcity-nightly-workflow.yaml

teamcity-nightly-sweeper.yaml

[github-actions]

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

[SarahFrench]

Left some comments!

Have you have this PR's GHAs labelling your fork of the TPG repo and seeing if your TeamCity project is picking up the static named branch ok?

[BBBmau]

@SarahFrench From teamcity config change PR:

new linked PR allows static branch filtering: we now only build if we detect a branch that matches both rules: +:refs/heads/UTC-* -:refs/heads/UTC-nightly-*

Once a period of time has passed (12 hours) the newly used branch for nightly tests will be renamed to match -:refs/heads/UTC-nightly-*. Allowing a new branch to be created which will be the only branch matching both rules. (As seen in the image above)

An explanation of the new gha workflow for this can be seen: hashicorp/terraform-provider-google#18447

Link to the TeamCity builds can be seen: https://hashicorp.teamcity.com/project/TerraformProviders_MauricioSTestProjectSameCommitNightlyTestsWork_GOOGLE_NIGHTLYTESTS?branch=refs%2Fheads%2FUTC-2024-06-14&mode=builds

had to update the cronjob due to it being the same time as when the teamcity builds are triggered. This caused teamcity to filter before the job was completed. Fixed now by setting the cronjob to run at 3AM UTC.

[SarahFrench]

Approving, but given that there are 2 workflows now you'll also need to add a new workflow in the google-beta repo that re-uses the teamcity-nightly-sweeper.yaml workflow.

Next step lets make sure your TeamCity test project is able to pull in the new branches each night.

[BBBmau]

Approving, but given that there are 2 workflows now you'll also need to add a new workflow in the google-beta repo that re-uses the teamcity-nightly-sweeper.yaml workflow.

Next step lets make sure your TeamCity test project is able to pull in the new branches each night.

We got a successful branch creation and build from last night, we can see it here: https://hashicorp.teamcity.com/buildConfiguration/TerraformProviders_MauricioSTestProjectSameCommitNightlyTestsWork_GOOGLE_NIGHTLYTESTS_GOOGLE_PACKAGE_ACCESSAPPROVAL?branch=&mode=branches#all-projects

I noticed that the sweeper didn't delete old branches, this was due to the filter not being updated. This PR already has the updated changes.

I'll make a PR for beta repo but after one more cronjob trigger we can merge this. 👍🏼

[BBBmau]

merging after seeing successful branch creation and branch sweeping with new workflow method. Other changes that were made were done in teamcity config files.