Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot specify trigger_template and webhook_config using google_cloudbuild_trigger #10434

Assignees
Milestone

Comments

@finlaye
Copy link

finlaye commented Oct 28, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

Currently when using the google_cloudbuild_trigger resource you can only specify one of webhook_config and trigger_template. This is not the same as in the console where you can select a source repo where you want to store your cloudbuild.yaml config AND you can configure a webhook. When attempting to specify both, this is the error shown

│ Error: ExactlyOne
│ 
│   with module.core_triggers.google_cloudbuild_trigger.example_trigger,
│   on triggers.tf line 6, in resource "google_cloudbuild_trigger" "example_trigger":
│    6: resource "google_cloudbuild_trigger" "example_trigger" {
│ 
│ "github": only one of
│ `github,pubsub_config,trigger_template,webhook_config` can be specified,
│ but `trigger_template,webhook_config` were specified.

New or Affected Resource(s)

  • google_cloudbuild_trigger

Potential Terraform Configuration

resource "google_cloudbuild_trigger" "filename-trigger" {
  trigger_template {
    branch_name = "master"
    repo_name   = "my-repo"
  }

  webhook_config {
    secret = "projects/123456789/secrets/example-secret/versions/1"
  }

  substitutions = {
    _FOO = "foo-bar"
    _BAZ = "qux"
  }

  filter = "_FOO.matches(\".*-bar\")"

  filename = "cloudbuild.yaml"
}

References

@finlaye finlaye changed the title Cannot specify trigger_template and webhook using google_cloudbuild_trigger Cannot specify trigger_template and webhook_config using google_cloudbuild_trigger Oct 28, 2021
@rileykarson rileykarson added this to the Goals milestone Nov 1, 2021
@tty47
Copy link

tty47 commented Nov 29, 2021

Hi there! @finlaye @rileykarson

I'm having the same issue, I cannot specify the repository when use a pubsub_config
Did you find any workaround?

@finlaye
Copy link
Author

finlaye commented Nov 29, 2021

Hi there! @finlaye @rileykarson

I'm having the same issue, I cannot specify the repository when use a pubsub_config Did you find any workaround?

Nope, no work around unfortunately :(

@tty47
Copy link

tty47 commented Nov 29, 2021

Hi there! @finlaye @rileykarson
I'm having the same issue, I cannot specify the repository when use a pubsub_config Did you find any workaround?

Nope, no work around unfortunately :(

:( let's wait until the feature will be added...

@bbhoss
Copy link

bbhoss commented Dec 1, 2021

Bummer. It seems like creating a scheduled cloud build job currently isn't possible with Terraform? :(

@tty47
Copy link

tty47 commented Dec 3, 2021

@bbhoss nope... so far is not possible to do it 😮‍💨

@ManuelLR
Copy link

Same error found using github + webhook_config

@shirakiya
Copy link

I would like the google provider to be able to request the sourceToBuild parameter described in this GCP document.
https://cloud.google.com/build/docs/api/reference/rest/v1/projects.locations.triggers#BuildTrigger

@amacarrilla
Copy link

Same problem here!!
Another one looking forward this feature

Thanks in advance

@mikelvizz
Copy link

+1

@abhinavrau
Copy link

I would like to work on this issue. I have added support for it on my fork of magic-modules here. I will be submitting a PR soon

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.