Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for manual builds, git source for webhook/pubsub triggered builds and filter field #4100

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Add support for manual builds, git source for webhook/pubsub triggered builds and filter field #4100

merged 1 commit into from
Mar 4, 2022

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#10779
Fixes hashicorp/terraform-provider-google#10434
Fixes hashicorp/terraform-provider-google#10387
Fixes hashicorp/terraform-provider-google#9755
Fixes hashicorp/terraform-provider-google#8374
Fixes hashicorp/terraform-provider-google#9189
Fixes hashicorp/terraform-provider-google#9883

Add support for REST fields sourceToBuild and gitFileSource which adds support for manual builds as well as adds support for webhook and pubsub triggered builds with source code.
Also added support for filter field that is used with webhook and pubsub triggered builds.
Also added examples for webhook, pubsub (with filter) and manual build.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudbuild: Add support for manual builds, git source for webhook/pubsub triggered builds and filter field

Derived from GoogleCloudPlatform/magic-modules#5738

@modular-magician
Add support for manual builds, git source for webhook/pubsub triggere…
e228d37 
…d builds and filter field (hashicorp#5738)

* add filter support for cloudbuild

* Add support for sourceToBuild and gitFileSource. Add examples for pubsub_config, webhook_config trigger and manual mode

* Add support for sourceToBuild and gitFileSource. Add examples for pubsub_config, webhook_config trigger and manual mode

* Fix description for field uri in sourceToBuild to be required

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit e511583 into hashicorp:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@modular-magician