Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_notebooks_instance resources recreated on every terraform apply without any configuration changes due to service_account_scopes #16587

Closed
7pandeys opened this issue Nov 22, 2023 · 3 comments

Comments

@7pandeys
Copy link

7pandeys commented Nov 22, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v1.5.6

provider.google v5.5.0

Affected Resource(s)

  • google_notebooks_instance

Terraform Configuration Files

resource "google_notebooks_instance" "instance" {
  name = "notebooks-instance"
  location = "us-west1-a"
  machine_type = "e2-medium"
  vm_image {
    project      = "deeplearning-platform-release"
    image_family = "tf-latest-cpu"
  service_account_scopes = [
    "https://www.googleapis.com/auth/bigquery",
    "https://www.googleapis.com/auth/devstorage.read_write",
    "https://www.googleapis.com/auth/cloud-platform",
    "https://www.googleapis.com/auth/userinfo.email"
  ]
  }
}

Debug Output

Note: No errors are shown in the output even with the debug flag activated.

Panic Output

There was no crash or panic produced during the terraform apply process.

Expected Behavior

Terraform should recognize that no changes have been made and should not attempt to recreate the notebook instance resources.

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

Recreating notebooks in Terraform's google_notebook_instance resource occurs only when the service_account_scopes parameter is utilized; otherwise, recreation does not take place.
Source

References

b/312911294

@7pandeys 7pandeys added the bug label Nov 22, 2023
@github-actions github-actions bot added forward/review In review; remove label to forward service/notebooks labels Nov 22, 2023
@edwardmedia edwardmedia self-assigned this Nov 22, 2023
@edwardmedia
Copy link
Contributor

The api does not have service_account_scopes in the response.

      - .service_account_scopes: element 0 has vanished
      - .service_account_scopes: element 1 has vanished
      - .service_account_scopes: element 2 has vanished
      - .service_account_scopes: element 3 has vanished

@edwardmedia edwardmedia removed the forward/review In review; remove label to forward label Nov 22, 2023
@edwardmedia edwardmedia removed their assignment Nov 22, 2023
@SarahFrench SarahFrench changed the title google_notebooks_instance resources recreated on every terraform apply without any configuration changes google_notebooks_instance resources recreated on every terraform apply without any configuration changes due to service_account_scopes Feb 6, 2024
@melinath
Copy link
Collaborator

This should be resolved by GoogleCloudPlatform/magic-modules#9915

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants